Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: webrtc/video/send_statistics_proxy.cc

Issue 2061423003: Refactor NACK bitrate allocation (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed data race Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/send_statistics_proxy.cc
diff --git a/webrtc/video/send_statistics_proxy.cc b/webrtc/video/send_statistics_proxy.cc
index abaa43800543ad29c7ef749848d0f1aa33954e4a..d918642ab8eb43b447f45195ab29a03aaeeca643 100644
--- a/webrtc/video/send_statistics_proxy.cc
+++ b/webrtc/video/send_statistics_proxy.cc
@@ -564,16 +564,17 @@ void SendStatisticsProxy::DataCountersUpdated(
uma_container_->first_rtp_stats_time_ms_ = clock_->TimeInMilliseconds();
}
-void SendStatisticsProxy::Notify(const BitrateStatistics& total_stats,
- const BitrateStatistics& retransmit_stats,
+void SendStatisticsProxy::Notify(uint32_t total_bitrate_bps,
+ uint32_t retransmit_bitrate_bps,
uint32_t ssrc) {
rtc::CritScope lock(&crit_);
VideoSendStream::StreamStats* stats = GetStatsEntry(ssrc);
if (!stats)
return;
- stats->total_bitrate_bps = total_stats.bitrate_bps;
- stats->retransmit_bitrate_bps = retransmit_stats.bitrate_bps;
+ stats->total_bitrate_bps = total_bitrate_bps;
+ stats->retransmit_bitrate_bps = retransmit_bitrate_bps;
+ // printf("@Nack bitrate for %u is %u\n", ssrc, retransmit_bitrate_bps);
danilchap 2016/06/23 12:46:12 do not forget to remove this line
sprang_webrtc 2016/06/28 09:12:33 Oops!
}
void SendStatisticsProxy::FrameCountUpdated(const FrameCounts& frame_counts,

Powered by Google App Engine
This is Rietveld 408576698