webrtc/video/rtp_stream_receiver.cc - Issue 2061423003: Refactor NACK bitrate allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/rtp_stream_receiver.cc

Issue 2061423003: Refactor NACK bitrate allocation (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed data race Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/rtp_stream_receiver.cc

diff --git a/webrtc/video/rtp_stream_receiver.cc b/webrtc/video/rtp_stream_receiver.cc

index 90e449c3323a03780e7b09fe5428e16bded178d7..bb2ec7ccfcb4c632742c900de21b8ba78f59ba42 100644

--- a/webrtc/video/rtp_stream_receiver.cc

+++ b/webrtc/video/rtp_stream_receiver.cc

@@ -185,12 +185,10 @@ RtpStreamReceiver::RtpStreamReceiver(

// Stats callback for CNAME changes.

rtp_rtcp_->RegisterRtcpStatisticsCallback(receive_stats_proxy);

- process_thread_->RegisterModule(rtp_receive_statistics_.get());

process_thread_->RegisterModule(rtp_rtcp_.get());

}

RtpStreamReceiver::~RtpStreamReceiver() {

- process_thread_->DeRegisterModule(rtp_receive_statistics_.get());

process_thread_->DeRegisterModule(rtp_rtcp_.get());

packet_router_->RemoveRtpModule(rtp_rtcp_.get());