webrtc/modules/congestion_controller/include/congestion_controller.h - Issue 2061423003: Refactor NACK bitrate allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/include/congestion_controller.h

Issue 2061423003: Refactor NACK bitrate allocation (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/congestion_controller.cc ('K') | « webrtc/modules/congestion_controller/congestion_controller.cc ('k') | webrtc/modules/rtp_rtcp/BUILD.gn » ('j') | webrtc/modules/rtp_rtcp/source/rtp_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/include/congestion_controller.h

diff --git a/webrtc/modules/congestion_controller/include/congestion_controller.h b/webrtc/modules/congestion_controller/include/congestion_controller.h

index 82906efc1d98d228bbddd13e37814315e7dcc137..07915898fe092f16a5ff52c519ce3f47f42347ea 100644

--- a/webrtc/modules/congestion_controller/include/congestion_controller.h

+++ b/webrtc/modules/congestion_controller/include/congestion_controller.h

@@ -32,6 +32,7 @@ class BitrateController;

class BitrateObserver;

class Clock;

class ProcessThread;

+class RateLimiter;

class RemoteBitrateEstimator;

class RemoteBitrateObserver;

class TransportFeedbackObserver;

@@ -83,6 +84,7 @@ class CongestionController : public CallStatsObserver, public Module {

virtual PacedSender* pacer() { return pacer_.get(); }

virtual PacketRouter* packet_router() { return packet_router_.get(); }

virtual TransportFeedbackObserver* GetTransportFeedbackObserver();

+ RateLimiter* GetRetransmissionRateLimiter();

// SetAllocatedSendBitrateLimits sets bitrates limits imposed by send codec

// settings.

@@ -121,6 +123,7 @@ class CongestionController : public CallStatsObserver, public Module {

const std::unique_ptr<PacedSender> pacer_;

const std::unique_ptr<RemoteBitrateEstimator> remote_bitrate_estimator_;

const std::unique_ptr<BitrateController> bitrate_controller_;

+ const std::unique_ptr<RateLimiter> retransmission_rate_limiter_;

RemoteEstimatorProxy remote_estimator_proxy_;

TransportFeedbackAdapter transport_feedback_adapter_;

int min_bitrate_bps_;