Fixing SCTP verbose packet logging.

Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org
BUG=619372
Committed: https://crrev.com/e9fc75ee7281d6e48c2f135c83a91807da04b763
Cr-Commit-Position: refs/heads/master@{#13119}

[Taylor Brandstetter, 2016-06-14 00:28:40]

Description was changed from

==========
Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

BUG=619372
==========

to

==========
Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org

BUG=619372
==========

[Taylor Brandstetter, 2016-06-14 00:28:52]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2016-06-14 00:28:59]

Description was changed from

==========
Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org

BUG=619372
==========

to

==========
Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org
BUG=619372
==========

[Taylor Brandstetter, 2016-06-14 00:29:15]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-06-14 00:29:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061093003/1

[commit-bot: I haz the power, 2016-06-14 00:30:38]

Description was changed from

==========
Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org
BUG=619372
==========

to

==========
Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org
BUG=619372
==========

[commit-bot: I haz the power, 2016-06-14 00:30:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-14 00:30:49]

Description was changed from

==========
Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org
BUG=619372
==========

to

==========
Fixing SCTP verbose packet logging.

We were passing the pointer to the sockaddr to usrsctp_dumppacket,
instead of the pointer to the data. So we were just logging random
bytes. The dangers of void*...

NOTRY=True
TBR=pthatcher@webrtc.org
BUG=619372

Committed: https://crrev.com/e9fc75ee7281d6e48c2f135c83a91807da04b763
Cr-Commit-Position: refs/heads/master@{#13119}
==========

[commit-bot: I haz the power, 2016-06-14 00:30:50]

Patchset 1 (id:??) landed as
https://crrev.com/e9fc75ee7281d6e48c2f135c83a91807da04b763
Cr-Commit-Position: refs/heads/master@{#13119}

[pthatcher1, 2016-06-14 19:10:31]

Wow, it was like this from the beginning:

https://webrtc-codereview.appspot.com/49159004/

Shame on me as the code reviewer.


Thanks for fixing it.