Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2060943009: Reland Fix crash parsing malformed rtp packet (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix crash parsing malformed rtp packet where header extesnsion size mismatch expected. Reland of https://codereview.webrtc.org/2067793003/ BUG=chromium:620242 R=åsapersson Committed: https://crrev.com/07ec26d1a9b697094fc8f92ec749d89d60ddea0f Cr-Commit-Position: refs/heads/master@{#13187}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 1 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
danilchap
rtp_packet.cc change is exactly the same, in unittest had to move constexpr uint_8 packet[] from ...
4 years, 6 months ago (2016-06-17 09:31:29 UTC) #2
åsapersson
lgtm
4 years, 6 months ago (2016-06-17 09:54:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060943009/20001
4 years, 6 months ago (2016-06-17 11:17:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 11:18:58 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 11:19:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07ec26d1a9b697094fc8f92ec749d89d60ddea0f
Cr-Commit-Position: refs/heads/master@{#13187}

Powered by Google App Engine
This is Rietveld 408576698