Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2060873002: Remove webrtc_all target (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc_all target Move all its configuration to all.gyp instead, which is not processed by Chromium builds (webrtc.gyp is). BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/86600246ca357d9c92a13c3bd431e0b2f3aab08d Cr-Commit-Position: refs/heads/master@{#13124}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added *.gyp to OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -119 lines) Patch
M OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M all.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
M webrtc/webrtc.gyp View 3 chunks +52 lines, -118 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
kjellander_webrtc
I think this is cleaner and it has the benefit that this is no longer ...
4 years, 6 months ago (2016-06-13 15:58:57 UTC) #3
pbos-webrtc
lgtm
4 years, 6 months ago (2016-06-13 17:11:17 UTC) #4
kjellander_webrtc
I tested this in a local Chromium checkout on Mac and iOS (since Linux, Android ...
4 years, 6 months ago (2016-06-13 19:16:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060873002/1
4 years, 6 months ago (2016-06-13 19:16:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6254)
4 years, 6 months ago (2016-06-13 19:28:40 UTC) #9
kjellander_webrtc
+henrika@webrtc.org for root owners
4 years, 6 months ago (2016-06-13 19:59:49 UTC) #11
henrika_webrtc
LGTM
4 years, 6 months ago (2016-06-14 08:12:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060873002/20001
4 years, 6 months ago (2016-06-14 08:16:37 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14145)
4 years, 6 months ago (2016-06-14 08:25:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060873002/20001
4 years, 6 months ago (2016-06-14 08:50:07 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 09:09:24 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 09:09:33 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86600246ca357d9c92a13c3bd431e0b2f3aab08d
Cr-Commit-Position: refs/heads/master@{#13124}

Powered by Google App Engine
This is Rietveld 408576698