webrtc/media/engine/webrtcvoiceengine.h - Issue 2060813002: Configure VoE NACK through AudioReceiveStream::Config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 2060813002: Configure VoE NACK through AudioReceiveStream::Config. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@wvoe_config_nack

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/media/engine/fakewebrtcvoiceengine.h ('k') | webrtc/media/engine/webrtcvoiceengine.cc » ('j') | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/media/engine/webrtcvoiceengine.h

diff --git a/webrtc/media/engine/webrtcvoiceengine.h b/webrtc/media/engine/webrtcvoiceengine.h

index c3fcfcc4f9ad0f9ba10bddd104b97da18f435802..e19fdb2085d9f3a212749805299ac376241f2a08 100644

--- a/webrtc/media/engine/webrtcvoiceengine.h

+++ b/webrtc/media/engine/webrtcvoiceengine.h

@@ -239,7 +239,6 @@ class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,

bool SetRecvCodecs(const std::vector<AudioCodec>& codecs);

bool SetSendCodecs(const std::vector<AudioCodec>& codecs);

bool SetSendCodecs(int channel, const webrtc::RtpParameters& rtp_parameters);

- void SetNack(int channel, bool nack_enabled);

bool SetSendCodec(int channel, const webrtc::CodecInst& send_codec);

bool SetLocalSource(uint32_t ssrc, AudioSource* source);

bool MuteStream(uint32_t ssrc, bool mute);

@@ -274,6 +273,7 @@ class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,

rtc::Optional<int> dtmf_payload_type_;

bool desired_playout_ = false;

bool recv_transport_cc_enabled_ = false;

+ bool recv_nack_enabled_ = false;

bool playout_ = false;

bool send_ = false;

webrtc::Call* const call_ = nullptr;