Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: webrtc/media/engine/fakewebrtcvoiceengine.h

Issue 2060813002: Configure VoE NACK through AudioReceiveStream::Config. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@wvoe_config_nack
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/fakewebrtcvoiceengine.h
diff --git a/webrtc/media/engine/fakewebrtcvoiceengine.h b/webrtc/media/engine/fakewebrtcvoiceengine.h
index 9a328e9b8d6dabf78bfee029ea3ce5dcf5d58948..7592bcea43cf906381d728f1ebf85ed66476bb92 100644
--- a/webrtc/media/engine/fakewebrtcvoiceengine.h
+++ b/webrtc/media/engine/fakewebrtcvoiceengine.h
@@ -135,11 +135,9 @@ class FakeWebRtcVoiceEngine
int max_encoding_bandwidth = 0;
bool opus_dtx = false;
bool red = false;
- bool nack = false;
int cn8_type = 13;
int cn16_type = 105;
int red_type = 117;
- int nack_max_packets = 0;
uint32_t send_ssrc = 0;
int associate_send_channel = -1;
std::vector<webrtc::CodecInst> recv_codecs;
@@ -181,12 +179,6 @@ class FakeWebRtcVoiceEngine
int GetMaxEncodingBandwidth(int channel) {
return channels_[channel]->max_encoding_bandwidth;
}
- bool GetNACK(int channel) {
- return channels_[channel]->nack;
- }
- int GetNACKMaxPackets(int channel) {
- return channels_[channel]->nack_max_packets;
- }
int GetSendCNPayloadType(int channel, bool wideband) {
return (wideband) ?
channels_[channel]->cn16_type :
@@ -495,12 +487,7 @@ class FakeWebRtcVoiceEngine
redPayloadtype = channels_[channel]->red_type;
return 0;
}
- WEBRTC_FUNC(SetNACKStatus, (int channel, bool enable, int maxNoPackets)) {
- WEBRTC_CHECK_CHANNEL(channel);
- channels_[channel]->nack = enable;
- channels_[channel]->nack_max_packets = maxNoPackets;
- return 0;
- }
+ WEBRTC_STUB(SetNACKStatus, (int channel, bool enable, int maxNoPackets));
// webrtc::VoEVolumeControl
WEBRTC_STUB(SetSpeakerVolume, (unsigned int));

Powered by Google App Engine
This is Rietveld 408576698