Add task queue to Call.

webrtc/call/bitrate_allocator.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_CALL_BITRATE_ALLOCATOR_H_
 #define WEBRTC_CALL_BITRATE_ALLOCATOR_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <utility>
 #include <vector>
 
-#include "webrtc/base/criticalsection.h"
-#include "webrtc/base/thread_annotations.h"
+#include "webrtc/base/sequenced_task_checker.h"
 
 namespace webrtc {
 
 class Clock;
 
 // Used by all send streams with adaptive bitrate, to get the currently
 // allocated bitrate for the send stream. The current network properties are
 // given at the same time, to let the send stream decide about possible loss
 // protection.
 class BitrateAllocatorObserver {
@@ skipping 82 matching lines @@
     int64_t allocated_bitrate_bps;
     double media_ratio;  // Part of the total bitrate used for media [0.0, 1.0].
   };
 
   // Calculates the minimum requested send bitrate and max padding bitrate and
   // calls LimitObserver::OnAllocationLimitsChanged.
   void UpdateAllocationLimits();
 
   typedef std::vector<ObserverConfig> ObserverConfigs;
   ObserverConfigs::iterator FindObserverConfig(
-      const BitrateAllocatorObserver* observer)
-      EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
+      const BitrateAllocatorObserver* observer);
 
   typedef std::multimap<uint32_t, const ObserverConfig*> ObserverSortingMap;
   typedef std::map<BitrateAllocatorObserver*, int> ObserverAllocation;
 
-  ObserverAllocation AllocateBitrates(uint32_t bitrate)
-      EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
+  ObserverAllocation AllocateBitrates(uint32_t bitrate);
 
-  ObserverAllocation ZeroRateAllocation() EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
-  ObserverAllocation LowRateAllocation(uint32_t bitrate)
-      EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
+  ObserverAllocation ZeroRateAllocation();
+  ObserverAllocation LowRateAllocation(uint32_t bitrate);
   ObserverAllocation NormalRateAllocation(uint32_t bitrate,
-                                          uint32_t sum_min_bitrates)
-      EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
+                                          uint32_t sum_min_bitrates);
   ObserverAllocation MaxRateAllocation(uint32_t bitrate,
-                                       uint32_t sum_max_bitrates)
-      EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
+                                       uint32_t sum_max_bitrates);
 
-  uint32_t LastAllocatedBitrate(const ObserverConfig& observer_config)
-      EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
+  uint32_t LastAllocatedBitrate(const ObserverConfig& observer_config);
   // The minimum bitrate required by this observer, including enable-hysteresis
   // if the observer is in a paused state.
-  uint32_t MinBitrateWithHysteresis(const ObserverConfig& observer_config)
-      EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
+  uint32_t MinBitrateWithHysteresis(const ObserverConfig& observer_config);
   // Splits |bitrate| evenly to observers already in |allocation|.
   // |include_zero_allocations| decides if zero allocations should be part of
   // the distribution or not. The allowed max bitrate is |max_multiplier| x
   // observer max bitrate.
   void DistributeBitrateEvenly(uint32_t bitrate,
                                bool include_zero_allocations,
                                int max_multiplier,
-                               ObserverAllocation* allocation)
-          EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
-  bool EnoughBitrateForAllObservers(uint32_t bitrate, uint32_t sum_min_bitrates)
-      EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
+                               ObserverAllocation* allocation);
+  bool EnoughBitrateForAllObservers(uint32_t bitrate,
+                                    uint32_t sum_min_bitrates);
 
   LimitObserver* const limit_observer_;
-
-  rtc::CriticalSection crit_sect_;
+  rtc::SequencedTaskChecker sequenced_checker_;
   // Stored in a list to keep track of the insertion order.
-  ObserverConfigs bitrate_observer_configs_ GUARDED_BY(crit_sect_);

[pbos-webrtc, 2016/07/13 12:35:38]

Can you have these GUARDED_BY the sequenced_checker_ instead?

[perkj_webrtc, 2016/07/14 10:11:27]

Done.

-  uint32_t last_bitrate_bps_ GUARDED_BY(crit_sect_);
-  uint32_t last_non_zero_bitrate_bps_ GUARDED_BY(crit_sect_);
-  uint8_t last_fraction_loss_ GUARDED_BY(crit_sect_);
-  int64_t last_rtt_ GUARDED_BY(crit_sect_);
+  ObserverConfigs bitrate_observer_configs_;
+  uint32_t last_bitrate_bps_;
+  uint32_t last_non_zero_bitrate_bps_;
+  uint8_t last_fraction_loss_;
+  int64_t last_rtt_;
   // Number of mute events based on too low BWE, not network up/down.
-  int num_pause_events_ GUARDED_BY(crit_sect_);
+  int num_pause_events_;
   Clock* const clock_;
   int64_t last_bwe_log_time_;
 };
 }  // namespace webrtc
 #endif  // WEBRTC_CALL_BITRATE_ALLOCATOR_H_