Add task queue to Call.

webrtc/test/fake_encoder.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 82 matching lines @@
       // TODO(holmer): The FakeEncoder should store the bits_available between
       // encodes so that it can compensate for oversized frames.
       stream_bytes *= 10;
     }
     if (stream_bytes > sizeof(encoded_buffer_))
       stream_bytes = sizeof(encoded_buffer_);
 
     EncodedImage encoded(
         encoded_buffer_, stream_bytes, sizeof(encoded_buffer_));
     encoded._timeStamp = input_image.timestamp();
+    encoded.ntp_time_ms_ = input_image.ntp_time_ms();

[tommi, 2016/07/06 11:15:01]

was this missing before?  Would it make sense to move setting these properties
into the constructor of EncodedImage so we won't have to update the call sites?

[perkj_webrtc, 2016/07/06 13:08:53]

EncodedImage is a horrible struct that is used in both Chrome and else where. So
updating ctor is not that easy. (pbos have a todo to clean this struct up but I
guess that todo will be left for the future).

I added it here to be able to test ViEEncoder, but it turns out ntp_timestamp is
not used by any real encoder implementations so I should probly not do that. It
is used by subclasses of EncodedFrame the receive side.
https://cs.chromium.org/chromium/src/third_party/webrtc/video_frame.h?sq=pack...

I refactored the test and is no longer dependent on any changes in this file.

     encoded.capture_time_ms_ = input_image.render_time_ms();
     encoded._frameType = (*frame_types)[i];
     encoded._encodedWidth = config_.simulcastStream[i].width;
     encoded._encodedHeight = config_.simulcastStream[i].height;
     // Always encode something on the first frame.
     if (min_stream_bits > bits_available && i > 0)

[tommi, 2016/07/06 11:15:02]

seems like this check should be done before we initialize EncodedImage.

[perkj_webrtc, 2016/07/06 13:08:54]

ok, should not matter much since its only pointer initialization.

       continue;
     assert(callback_ != NULL);

[tommi, 2016/07/06 11:15:01]

can you change all assert()s to RTC_DCHECK in this file?

[perkj_webrtc, 2016/07/06 13:08:53]

Done.

     if (callback_->Encoded(encoded, &specifics, NULL) != 0)
       return -1;
     bits_available -= std::min(encoded._length * 8, bits_available);
   }
   return 0;
 }
 
 int32_t FakeEncoder::RegisterEncodeCompleteCallback(
     EncodedImageCallback* callback) {
   callback_ = callback;
@@ skipping 77 matching lines @@
       delay_ms_(delay_ms) {}
 
 int32_t DelayedEncoder::Encode(const VideoFrame& input_image,
                                const CodecSpecificInfo* codec_specific_info,
                                const std::vector<FrameType>* frame_types) {
   SleepMs(delay_ms_);
   return FakeEncoder::Encode(input_image, codec_specific_info, frame_types);
 }
 }  // namespace test
 }  // namespace webrtc