Add task queue to Call.

webrtc/call/bitrate_allocator.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  *
  */
@@ skipping 16 matching lines @@
 // Require a bitrate increase of max(10%, 20kbps) to resume paused streams.
 const double kToggleFactor = 0.1;
 const uint32_t kMinToggleBitrateBps = 20000;
 
 BitrateAllocator::BitrateAllocator(LimitObserver* limit_observer)
     : limit_observer_(limit_observer),
       bitrate_observer_configs_(),
       last_bitrate_bps_(kDefaultBitrateBps),
       last_non_zero_bitrate_bps_(kDefaultBitrateBps),
       last_fraction_loss_(0),
-      last_rtt_(0) {}
+      last_rtt_(0) {
+  thread_checker_.DetachFromThread();
+}
 
 void BitrateAllocator::OnNetworkChanged(uint32_t target_bitrate_bps,
                                         uint8_t fraction_loss,
                                         int64_t rtt) {
-  rtc::CritScope lock(&crit_sect_);
+  RTC_DCHECK_RUN_ON(&thread_checker_);
   last_bitrate_bps_ = target_bitrate_bps;
   last_non_zero_bitrate_bps_ =
       target_bitrate_bps > 0 ? target_bitrate_bps : last_non_zero_bitrate_bps_;
   last_fraction_loss_ = fraction_loss;
   last_rtt_ = rtt;
 
   ObserverAllocation allocation = AllocateBitrates(target_bitrate_bps);
   for (const auto& kv : allocation) {
     kv.first->OnBitrateUpdated(kv.second, last_fraction_loss_, last_rtt_);
   }
   last_allocation_ = allocation;
 }
 
 void BitrateAllocator::AddObserver(BitrateAllocatorObserver* observer,
                                    uint32_t min_bitrate_bps,
                                    uint32_t max_bitrate_bps,
                                    uint32_t pad_up_bitrate_bps,
                                    bool enforce_min_bitrate) {
-  rtc::CritScope lock(&crit_sect_);
+  RTC_DCHECK_RUN_ON(&thread_checker_);
   auto it = FindObserverConfig(observer);
 
   // Update settings if the observer already exists, create a new one otherwise.
   if (it != bitrate_observer_configs_.end()) {
     it->min_bitrate_bps = min_bitrate_bps;
     it->max_bitrate_bps = max_bitrate_bps;
     it->pad_up_bitrate_bps = pad_up_bitrate_bps;
     it->enforce_min_bitrate = enforce_min_bitrate;
   } else {
     bitrate_observer_configs_.push_back(
@@ skipping 13 matching lines @@
     // observer know that it can not produce frames.
     allocation = AllocateBitrates(last_non_zero_bitrate_bps_);
     observer->OnBitrateUpdated(0, last_fraction_loss_, last_rtt_);
   }
   UpdateAllocationLimits();
 
   last_allocation_ = allocation;
 }
 
 void BitrateAllocator::UpdateAllocationLimits() {
+  RTC_DCHECK_RUN_ON(&thread_checker_);
   uint32_t total_requested_padding_bitrate = 0;
   uint32_t total_requested_min_bitrate = 0;
 
-  {
-    rtc::CritScope lock(&crit_sect_);
     for (const auto& config : bitrate_observer_configs_) {

[tommi, 2016/06/29 14:49:41]

run git cl format

       if (config.enforce_min_bitrate) {
         total_requested_min_bitrate += config.min_bitrate_bps;
       }
       total_requested_padding_bitrate += config.pad_up_bitrate_bps;
     }
-  }
 
   limit_observer_->OnAllocationLimitsChanged(total_requested_min_bitrate,
                                              total_requested_padding_bitrate);
 }
 
 void BitrateAllocator::RemoveObserver(BitrateAllocatorObserver* observer) {
-  {
-    rtc::CritScope lock(&crit_sect_);
-    auto it = FindObserverConfig(observer);
-    if (it != bitrate_observer_configs_.end()) {
-      bitrate_observer_configs_.erase(it);
+  RTC_DCHECK_RUN_ON(&thread_checker_);
+  auto it = FindObserverConfig(observer);
+  if (it != bitrate_observer_configs_.end()) {
+    bitrate_observer_configs_.erase(it);
     }

[tommi, 2016/06/29 14:49:41]

please :)

-  }
+
   UpdateAllocationLimits();
 }
 
 int BitrateAllocator::GetStartBitrate(BitrateAllocatorObserver* observer) {
-  rtc::CritScope lock(&crit_sect_);
+  RTC_DCHECK_RUN_ON(&thread_checker_);
   const auto& it = last_allocation_.find(observer);
   if (it != last_allocation_.end())
     return it->second;
 
   // This is a new observer that has not yet been started. Assume that if it is
   // added, all observers would split the available bitrate evenly.
   return last_non_zero_bitrate_bps_ /
          static_cast<int>((bitrate_observer_configs_.size() + 1));
 }
 
@@ skipping 190 matching lines @@
   uint32_t extra_bitrate_per_observer = (bitrate - sum_min_bitrates) /
       static_cast<uint32_t>(bitrate_observer_configs_.size());
   for (const auto& observer_config : bitrate_observer_configs_) {
     if (observer_config.min_bitrate_bps + extra_bitrate_per_observer <
         MinBitrateWithHysteresis(observer_config))
       return false;
   }
   return true;
 }
 }  // namespace webrtc