Move webrtc/audio_*.h to webrtc/api/call

Move webrtc/audio_*.h to webrtc/api/call

BUG=webrtc:5878
NOTRY=True

Committed: https://crrev.com/a69d973267d4a10cbb51b9c47023ba4a3c854167
Cr-Commit-Position: refs/heads/master@{#13996}

[kjellander_webrtc, 2016-06-10 09:45:41]

Description was changed from

==========
Move webrtc/audio_*.h to webrtc/api/audio

BUG=webrtc:5878
==========

to

==========
Move webrtc/audio_*.h to webrtc/api/audio

BUG=webrtc:5878
==========

[kjellander_webrtc, 2016-06-10 09:45:41]

kjellander@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[kjellander_webrtc, 2016-06-10 10:11:17]

Fredrik, is this how we want it to be?

[kjellander_webrtc, 2016-06-10 11:00:59]

Description was changed from

==========
Move webrtc/audio_*.h to webrtc/api/audio

BUG=webrtc:5878
==========

to

==========
Move webrtc/audio_*.h to webrtc/api/audio

BUG=webrtc:5878
NOTRY=True
==========

[the sun, 2016-06-14 09:30:35]

On 2016/06/10 10:11:17, kjellander_webrtc wrote:
> Fredrik, is this how we want it to be?

As agreed offline, put API in call folder instead.

[the sun, 2016-06-14 09:32:41]

On 2016/06/14 09:30:35, the sun wrote:
> On 2016/06/10 10:11:17, kjellander_webrtc wrote:
> > Fredrik, is this how we want it to be?
> 
> As agreed offline, put API in call folder instead.

That is, the api/audio/ stuff goes in api/call/ instead, as it will be joined by
more parts of the call API.

[the sun, 2016-06-14 09:40:27]

https://codereview.webrtc.org/2059703002/diff/20001/webrtc/api/BUILD.gn
File webrtc/api/BUILD.gn (right):

https://codereview.webrtc.org/2059703002/diff/20001/webrtc/api/BUILD.gn#newco...
webrtc/api/BUILD.gn:21: "audio/audio_send_stream.h",
!!

[kjellander_webrtc, 2016-06-14 18:49:45]

Description was changed from

==========
Move webrtc/audio_*.h to webrtc/api/audio

BUG=webrtc:5878
NOTRY=True
==========

to

==========
Move webrtc/audio_*.h to webrtc/api/call

BUG=webrtc:5878
NOTRY=True
==========

[kjellander_webrtc, 2016-06-14 19:24:43]

Patchset #3 (id:40001) has been deleted

[kjellander_webrtc, 2016-06-14 20:17:46]

PTAL

https://codereview.webrtc.org/2059703002/diff/20001/webrtc/api/BUILD.gn
File webrtc/api/BUILD.gn (right):

https://codereview.webrtc.org/2059703002/diff/20001/webrtc/api/BUILD.gn#newco...
webrtc/api/BUILD.gn:21: "audio/audio_send_stream.h",
On 2016/06/14 09:40:27, the sun wrote:
> !!

Whops, I only fixed api.gyp apparently.

[the sun, 2016-06-15 09:09:52]

solenberg@webrtc.org changed reviewers:
+ tommi@webrtc.org

[the sun, 2016-06-15 09:09:53]

LGTM

(adding tommi@ for root ownership-ness)

https://codereview.webrtc.org/2059703002/diff/60001/webrtc/common.gyp
File webrtc/common.gyp (left):

https://codereview.webrtc.org/2059703002/diff/60001/webrtc/common.gyp#oldcode15
webrtc/common.gyp:15: 'audio_sink.h',
So this bothers me a *little* bit.

The reason audio_sink.h was added here was so that those depending on it would
pull in as little as possible (adding it in webrtc.gyp:webrtc would have
otherwise been the natural place for it). Now, everyone using AudioSinkInterface
implicitly knows about the whole Call API.

Since we're not adding a dependency in those places on the webrtc.gyp:webrtc
target (and everything it pulls in), but only on the call_api target, I think
I'm fine with it though.

[kjellander_webrtc, 2016-06-15 12:32:16]

https://codereview.webrtc.org/2059703002/diff/60001/webrtc/common.gyp
File webrtc/common.gyp (left):

https://codereview.webrtc.org/2059703002/diff/60001/webrtc/common.gyp#oldcode15
webrtc/common.gyp:15: 'audio_sink.h',
On 2016/06/15 09:09:52, the sun wrote:
> So this bothers me a *little* bit.
> 
> The reason audio_sink.h was added here was so that those depending on it would
> pull in as little as possible (adding it in webrtc.gyp:webrtc would have
> otherwise been the natural place for it). Now, everyone using
AudioSinkInterface
> implicitly knows about the whole Call API.
> 
> Since we're not adding a dependency in those places on the webrtc.gyp:webrtc
> target (and everything it pulls in), but only on the call_api target, I think
> I'm fine with it though.

Yeah, a header should definitely not be present in multiple targets IMO.

[tommi, 2016-06-15 13:46:10]

lgtm

[the sun, 2016-08-25 09:34:11]

ping... would love to see this landed

[kjellander_webrtc, 2016-08-25 12:58:22]

On 2016/08/25 09:34:11, the sun wrote:
> ping... would love to see this landed

Thanks. I rebased it now and we'll how (un)healthy it is.

[kjellander_webrtc, 2016-08-31 14:10:37]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-08-31 14:10:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2059703002/#ps120001 (title:
"Rebased on top of d565b73121b1b7672fb7d1f115bbbbb137a838eb")

[commit-bot: I haz the power, 2016-08-31 14:10:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 14:33:09]

Description was changed from

==========
Move webrtc/audio_*.h to webrtc/api/call

BUG=webrtc:5878
NOTRY=True
==========

to

==========
Move webrtc/audio_*.h to webrtc/api/call

BUG=webrtc:5878
NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-31 14:33:11]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-08-31 14:33:19]

Description was changed from

==========
Move webrtc/audio_*.h to webrtc/api/call

BUG=webrtc:5878
NOTRY=True
==========

to

==========
Move webrtc/audio_*.h to webrtc/api/call

BUG=webrtc:5878
NOTRY=True

Committed: https://crrev.com/a69d973267d4a10cbb51b9c47023ba4a3c854167
Cr-Commit-Position: refs/heads/master@{#13996}
==========

[commit-bot: I haz the power, 2016-08-31 14:33:21]

Patchset 6 (id:??) landed as
https://crrev.com/a69d973267d4a10cbb51b9c47023ba4a3c854167
Cr-Commit-Position: refs/heads/master@{#13996}