Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2058753003: Adjust the amount of VP8 encoder threads for Android builds. (Closed)

Created:
4 years, 6 months ago by AlexG
Modified:
4 years, 6 months ago
Reviewers:
jackychen, marpan2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, sprang_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adjust the amount of VP8 encoder threads for Android builds. Current number of threads selection code does not work well for Android builds - middle and low end devices are having hard time encoding VGA and QVGA with just one thread. Increase the amount of vp8 encoder threads for 180p and above resolution. Also limit maximum number of thread to 3, since for 8 core devices most of time 4 cores are idle when thermal throttling kicks in. BUG=b/27946721 R=marpan@webrtc.org Committed: https://crrev.com/2cc8baa14433871f0c47d3a772d6ea0c3975172d Cr-Commit-Position: refs/heads/master@{#13142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
AlexG
PTAL
4 years, 6 months ago (2016-06-10 23:24:37 UTC) #2
mflodman
4 years, 6 months ago (2016-06-12 07:02:20 UTC) #3
AlexG
Ping :)
4 years, 6 months ago (2016-06-14 17:06:14 UTC) #4
marpan2
lgtm
4 years, 6 months ago (2016-06-14 17:15:17 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058753003/1
4 years, 6 months ago (2016-06-14 20:25:43 UTC) #7
AlexG
4 years, 6 months ago (2016-06-14 21:28:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2cc8baa14433871f0c47d3a772d6ea0c3975172d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698