Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2057533002: Delete some unused header files. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, sdk-team_agora.io, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete some unused header files. NOTRY=True # two of the androids bots are not cooperating BUG= Committed: https://crrev.com/602844aa5e2c0685fb4fcb579f3f54b2a48a1c8b Cr-Commit-Position: refs/heads/master@{#13099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -90 lines) Patch
D webrtc/modules/video_capture/video_capture_internal.h View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/modules/video_coding/test/release_test.h View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/tools/agc/fake_agc.h View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
nisse-webrtc
These files are unreferenced in both webrtc and chrome.
4 years, 6 months ago (2016-06-09 13:18:14 UTC) #2
tommi
lgtm
4 years, 6 months ago (2016-06-09 13:45:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057533002/1
4 years, 6 months ago (2016-06-09 13:46:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14026)
4 years, 6 months ago (2016-06-09 13:57:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057533002/1
4 years, 6 months ago (2016-06-10 08:49:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14052)
4 years, 6 months ago (2016-06-10 08:59:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057533002/1
4 years, 6 months ago (2016-06-10 09:06:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14054)
4 years, 6 months ago (2016-06-10 09:13:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057533002/1
4 years, 6 months ago (2016-06-10 10:25:16 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14058)
4 years, 6 months ago (2016-06-10 10:35:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057533002/1
4 years, 6 months ago (2016-06-10 11:39:32 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 11:41:11 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 11:41:22 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/602844aa5e2c0685fb4fcb579f3f54b2a48a1c8b
Cr-Commit-Position: refs/heads/master@{#13099}

Powered by Google App Engine
This is Rietveld 408576698