Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2056713002: Add suppressions for memcheck errors. (Closed)

Created:
4 years, 6 months ago by åsapersson
Modified:
4 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add suppressions for memcheck errors. BUG=webrtc:5986, webrtc:5987, webrtc:5988, webrtc:5989 NOTRY=True Committed: https://crrev.com/2c1bec3fcc5f6ab723bc71699001bc16d31468bf Cr-Commit-Position: refs/heads/master@{#13091}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 2 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
åsapersson
4 years, 6 months ago (2016-06-09 12:59:35 UTC) #3
kjellander_webrtc
lgtm with a suggestion about a wider suppression. https://codereview.webrtc.org/2056713002/diff/20001/tools/valgrind-webrtc/memcheck/suppressions.txt File tools/valgrind-webrtc/memcheck/suppressions.txt (right): https://codereview.webrtc.org/2056713002/diff/20001/tools/valgrind-webrtc/memcheck/suppressions.txt#newcode479 tools/valgrind-webrtc/memcheck/suppressions.txt:479: fun:_ZN6webrtc11VoEBaseImpl4InitEPNS_17AudioDeviceModuleEPNS_15AudioProcessingERKN3rtc13scoped_refptrINS_19AudioDecoderFactoryEEE ...
4 years, 6 months ago (2016-06-09 13:57:33 UTC) #5
åsapersson
https://codereview.webrtc.org/2056713002/diff/20001/tools/valgrind-webrtc/memcheck/suppressions.txt File tools/valgrind-webrtc/memcheck/suppressions.txt (right): https://codereview.webrtc.org/2056713002/diff/20001/tools/valgrind-webrtc/memcheck/suppressions.txt#newcode479 tools/valgrind-webrtc/memcheck/suppressions.txt:479: fun:_ZN6webrtc11VoEBaseImpl4InitEPNS_17AudioDeviceModuleEPNS_15AudioProcessingERKN3rtc13scoped_refptrINS_19AudioDecoderFactoryEEE On 2016/06/09 13:57:33, kjellander_webrtc wrote: > I think ...
4 years, 6 months ago (2016-06-09 15:00:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056713002/40001
4 years, 6 months ago (2016-06-09 15:06:36 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 15:08:13 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 15:08:25 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2c1bec3fcc5f6ab723bc71699001bc16d31468bf
Cr-Commit-Position: refs/heads/master@{#13091}

Powered by Google App Engine
This is Rietveld 408576698