Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2055473002: Moves macros ACCESS_ON/RUN_ON from thread_annotations to thread_checker (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moves macros ACCESS_ON/RUN_ON from thread_annotations to thread_checker to be compatible with projects that has own base/thread_annotation.h NOTRY=TRUE Committed: https://crrev.com/8e85b3c34929fc078101b793abc2abd3e4d6fe9a Cr-Commit-Position: refs/heads/master@{#13090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M webrtc/base/thread_annotations.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/base/thread_checker.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
danilchap
having additional macros in thread_annotation.h creates problem when another project that use webrtc has own ...
4 years, 6 months ago (2016-06-08 19:30:56 UTC) #2
tommi
lgtm
4 years, 6 months ago (2016-06-09 13:51:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055473002/1
4 years, 6 months ago (2016-06-09 14:54:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 14:55:29 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 14:55:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e85b3c34929fc078101b793abc2abd3e4d6fe9a
Cr-Commit-Position: refs/heads/master@{#13090}

Powered by Google App Engine
This is Rietveld 408576698