Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2054683002: Add suppressions for memcheck errors. (Closed)

Created:
4 years, 6 months ago by åsapersson
Modified:
4 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add suppressions for memcheck errors. BUG=webrtc:5983, webrtc:5984 NOTRY=True Committed: https://crrev.com/1503df6aefd268ee10e84a5b0df12a4893f18859 Cr-Commit-Position: refs/heads/master@{#13084}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
åsapersson
4 years, 6 months ago (2016-06-09 06:30:43 UTC) #3
kjellander_webrtc
Nice work, just move one suppression. https://codereview.webrtc.org/2054683002/diff/1/tools/valgrind-webrtc/memcheck/suppressions.txt File tools/valgrind-webrtc/memcheck/suppressions.txt (right): https://codereview.webrtc.org/2054683002/diff/1/tools/valgrind-webrtc/memcheck/suppressions.txt#newcode436 tools/valgrind-webrtc/memcheck/suppressions.txt:436: Ubuntu_Precise_Itoa_Optimized_Code Move this ...
4 years, 6 months ago (2016-06-09 07:12:14 UTC) #4
åsapersson
https://codereview.webrtc.org/2054683002/diff/1/tools/valgrind-webrtc/memcheck/suppressions.txt File tools/valgrind-webrtc/memcheck/suppressions.txt (right): https://codereview.webrtc.org/2054683002/diff/1/tools/valgrind-webrtc/memcheck/suppressions.txt#newcode436 tools/valgrind-webrtc/memcheck/suppressions.txt:436: Ubuntu_Precise_Itoa_Optimized_Code On 2016/06/09 07:12:14, kjellander_webrtc wrote: > Move this ...
4 years, 6 months ago (2016-06-09 07:19:53 UTC) #5
kjellander_webrtc
lgtm
4 years, 6 months ago (2016-06-09 07:42:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054683002/20001
4 years, 6 months ago (2016-06-09 07:45:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 07:46:37 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 07:46:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1503df6aefd268ee10e84a5b0df12a4893f18859
Cr-Commit-Position: refs/heads/master@{#13084}

Powered by Google App Engine
This is Rietveld 408576698