|
|
Created:
4 years, 6 months ago by kjellander_webrtc Modified:
4 years, 6 months ago Reviewers:
perkj_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionGN: Add peerconnection_unittests
BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
Committed: https://crrev.com/fd5b4e9435b2b3f7069ecfda02ec40931c4b642b
Cr-Commit-Position: refs/heads/master@{#13116}
Patch Set 1 : GN: Add peerconnection_unittests #
Total comments: 4
Patch Set 2 : Improved documentation #
Created: 4 years, 6 months ago
Messages
Total messages: 18 (11 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
kjellander@webrtc.org changed reviewers: + perkj@webrtc.org
lgtm if you can rephrase the comments a bit. https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn#newc... webrtc/api/BUILD.gn:140: # adds these flags so to cancel them out they need to come from a config and Can this sentence be rephrased a bit. I am having trouble understanding what it means. https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn#newc... webrtc/api/BUILD.gn:220: # adds -Wall, and this flag have to be after -Wall -- so they need to this/ these? .. this flag have to be after -- so they need... ?
https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn#newc... webrtc/api/BUILD.gn:140: # adds these flags so to cancel them out they need to come from a config and On 2016/06/13 14:57:03, perkj_webrtc wrote: > Can this sentence be rephrased a bit. I am having trouble understanding what it > means. Done. https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn#newc... webrtc/api/BUILD.gn:220: # adds -Wall, and this flag have to be after -Wall -- so they need to On 2016/06/13 14:57:03, perkj_webrtc wrote: > this/ these? .. this flag have to be after -- so they need... ? You're right, I clarified this and the above.
The CQ bit was checked by kjellander@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org Link to the patchset: https://codereview.webrtc.org/2054413002/#ps120001 (title: "Improved documentation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054413002/120001
The CQ bit was unchecked by kjellander@webrtc.org
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054413002/120001
Message was sent while issue was closed.
Committed patchset #2 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== GN: Add peerconnection_unittests BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. NOTRY=True ========== to ========== GN: Add peerconnection_unittests BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. NOTRY=True Committed: https://crrev.com/fd5b4e9435b2b3f7069ecfda02ec40931c4b642b Cr-Commit-Position: refs/heads/master@{#13116} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fd5b4e9435b2b3f7069ecfda02ec40931c4b642b Cr-Commit-Position: refs/heads/master@{#13116} |