GN: Add peerconnection_unittests

GN: Add peerconnection_unittests

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True

Committed: https://crrev.com/fd5b4e9435b2b3f7069ecfda02ec40931c4b642b
Cr-Commit-Position: refs/heads/master@{#13116}

[kjellander_webrtc, 2016-06-13 07:57:37]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-06-13 09:18:11]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-06-13 09:18:18]

Patchset #1 (id:40001) has been deleted

[kjellander_webrtc, 2016-06-13 09:18:28]

Patchset #1 (id:60001) has been deleted

[kjellander_webrtc, 2016-06-13 09:29:06]

Patchset #1 (id:80001) has been deleted

[kjellander_webrtc, 2016-06-13 09:30:11]

kjellander@webrtc.org changed reviewers:
+ perkj@webrtc.org

[perkj_webrtc, 2016-06-13 14:57:03]

lgtm if you can rephrase the comments a bit.

https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn
File webrtc/api/BUILD.gn (right):

https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn#newc...
webrtc/api/BUILD.gn:140: # adds these flags so to cancel them out they need to
come from a config and
Can this sentence be rephrased a bit. I am having trouble understanding what it
means.

https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn#newc...
webrtc/api/BUILD.gn:220: # adds -Wall, and this flag have to be after -Wall --
so they need to
this/ these? .. this flag have to be after -- so they need... ?

[kjellander_webrtc, 2016-06-13 18:41:23]

https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn
File webrtc/api/BUILD.gn (right):

https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn#newc...
webrtc/api/BUILD.gn:140: # adds these flags so to cancel them out they need to
come from a config and
On 2016/06/13 14:57:03, perkj_webrtc wrote:
> Can this sentence be rephrased a bit. I am having trouble understanding what
it
> means.

Done.

https://codereview.webrtc.org/2054413002/diff/100001/webrtc/api/BUILD.gn#newc...
webrtc/api/BUILD.gn:220: # adds -Wall, and this flag have to be after -Wall --
so they need to
On 2016/06/13 14:57:03, perkj_webrtc wrote:
> this/ these? .. this flag have to be after -- so they need... ? 

You're right, I clarified this and the above.

[kjellander_webrtc, 2016-06-13 18:41:30]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-06-13 18:41:31]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2054413002/#ps120001 (title:
"Improved documentation")

[commit-bot: I haz the power, 2016-06-13 18:41:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054413002/120001

[kjellander_webrtc, 2016-06-13 18:41:56]

The CQ bit was unchecked by kjellander@webrtc.org

[kjellander_webrtc, 2016-06-13 19:06:53]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-06-13 19:06:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054413002/120001

[commit-bot: I haz the power, 2016-06-13 19:08:39]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-06-13 19:08:41]

Description was changed from

==========
GN: Add peerconnection_unittests

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
==========

to

==========
GN: Add peerconnection_unittests

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True

Committed: https://crrev.com/fd5b4e9435b2b3f7069ecfda02ec40931c4b642b
Cr-Commit-Position: refs/heads/master@{#13116}
==========

[commit-bot: I haz the power, 2016-06-13 19:08:42]

Patchset 2 (id:??) landed as
https://crrev.com/fd5b4e9435b2b3f7069ecfda02ec40931c4b642b
Cr-Commit-Position: refs/heads/master@{#13116}