webrtc/system_wrappers/include/trace.h - Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/include/trace.h

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix use of ASSERT instead of ASSERT_TRUE in test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/system_wrappers/include/trace.h

diff --git a/webrtc/system_wrappers/include/trace.h b/webrtc/system_wrappers/include/trace.h

index 25a3d746c4ff312602f946f6b737bcea91dbc9e2..e3ca3c68407cfd28541119bc9e668e6e72050ad3 100644

--- a/webrtc/system_wrappers/include/trace.h

+++ b/webrtc/system_wrappers/include/trace.h

@@ -60,9 +60,6 @@ class Trace {

static int32_t SetTraceFile(const char* file_name,

const bool add_file_counter = false);

- // Returns the name of the file that the trace is currently writing to.

- static int32_t TraceFile(char file_name[1024]);

// Registers callback to receive trace messages.

// TODO(hellner): Why not use OutStream instead? Why is TraceCallback not

// defined in this file?

« no previous file with comments | « webrtc/system_wrappers/include/file_wrapper.h ('k') | webrtc/system_wrappers/source/data_log.cc » ('j') | no next file with comments »