webrtc/modules/audio_processing/transient/click_annotate.cc - Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/transient/click_annotate.cc

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix use of ASSERT instead of ASSERT_TRUE in test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/transient/file_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/transient/click_annotate.cc

diff --git a/webrtc/modules/audio_processing/transient/click_annotate.cc b/webrtc/modules/audio_processing/transient/click_annotate.cc

index dd1c346ebd637db1c122567431335e756d67269c..b03a714c287979480929576130e24d549ed2f06e 100644

--- a/webrtc/modules/audio_processing/transient/click_annotate.cc

+++ b/webrtc/modules/audio_processing/transient/click_annotate.cc

@@ -40,15 +40,15 @@ int main(int argc, char* argv[]) {

}

std::unique_ptr<FileWrapper> pcm_file(FileWrapper::Create());

- pcm_file->OpenFile(argv[1], true, false, false);

- if (!pcm_file->Open()) {

+ pcm_file->OpenFile(argv[1], true);

+ if (!pcm_file->is_open()) {

printf("\nThe %s could not be opened.\n\n", argv[1]);

return -1;

}

std::unique_ptr<FileWrapper> dat_file(FileWrapper::Create());

- dat_file->OpenFile(argv[2], false, false, false);

- if (!dat_file->Open()) {

+ dat_file->OpenFile(argv[2], false);

+ if (!dat_file->is_open()) {

printf("\nThe %s could not be opened.\n\n", argv[2]);

return -1;

}