Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: webrtc/call/rtc_event_log.cc

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix use of ASSERT instead of ASSERT_TRUE in test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/call/rtc_event_log_helper_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/rtc_event_log.cc
diff --git a/webrtc/call/rtc_event_log.cc b/webrtc/call/rtc_event_log.cc
index 90145735eddf90eb720b10a02f1e30f6b2b66196..7ea1e167a1e0a15e905c1e47bb722de84b97018f 100644
--- a/webrtc/call/rtc_event_log.cc
+++ b/webrtc/call/rtc_event_log.cc
@@ -188,7 +188,7 @@ bool RtcEventLogImpl::StartLogging(const std::string& file_name,
message.start_time = clock_->TimeInMicroseconds();
message.stop_time = std::numeric_limits<int64_t>::max();
message.file.reset(FileWrapper::Create());
- if (message.file->OpenFile(file_name.c_str(), false) != 0) {
+ if (!message.file->OpenFile(file_name.c_str(), false)) {
LOG(LS_ERROR) << "Can't open file. WebRTC event log not started.";
return false;
}
@@ -222,7 +222,7 @@ bool RtcEventLogImpl::StartLogging(rtc::PlatformFile platform_file,
}
return false;
}
- if (message.file->OpenFromFileHandle(file_handle, true, false) != 0) {
+ if (!message.file->OpenFromFileHandle(file_handle)) {
LOG(LS_ERROR) << "Can't open file. WebRTC event log not started.";
return false;
}
@@ -443,7 +443,7 @@ bool RtcEventLog::ParseRtcEventLog(const std::string& file_name,
char tmp_buffer[1024];
int bytes_read = 0;
std::unique_ptr<FileWrapper> dump_file(FileWrapper::Create());
- if (dump_file->OpenFile(file_name.c_str(), true) != 0) {
+ if (!dump_file->OpenFile(file_name.c_str(), true)) {
return false;
}
std::string dump_buffer;
« no previous file with comments | « no previous file | webrtc/call/rtc_event_log_helper_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698