webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc - Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix compile error in func_test_manager.cc Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/common_types.h ('K') | « webrtc/modules/video_coding/utility/ivf_file_writer.cc ('k') | webrtc/system_wrappers/BUILD.gn » ('j') | webrtc/system_wrappers/include/file_wrapper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc

diff --git a/webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc b/webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc

index 303502487d8fc590b4e210c46c3a95aad5d43295..4442df4458ae582a5592ea2958a2261c203fb2ce 100644

--- a/webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc

+++ b/webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc

@@ -124,7 +124,7 @@ class IvfFileWriterTest : public ::testing::Test {

VerifyDummyTestFrames(out_file.get(), kNumFrames);

out_file->Flush();

- EXPECT_EQ(0, out_file->CloseFile());

+ out_file->CloseFile();

bool file_removed = false;

for (int i = 0; i < kMaxFileRetries; ++i) {

« webrtc/common_types.h ('K') | « webrtc/modules/video_coding/utility/ivf_file_writer.cc ('k') | webrtc/system_wrappers/BUILD.gn » ('j') | webrtc/system_wrappers/include/file_wrapper.h » ('J')