webrtc/modules/media_file/media_file_impl.cc - Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/media_file/media_file_impl.cc

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix compile error in func_test_manager.cc Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/common_types.h ('K') | « webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc ('k') | webrtc/modules/video_coding/utility/ivf_file_writer.cc » ('j') | webrtc/system_wrappers/include/file_wrapper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/media_file/media_file_impl.cc

diff --git a/webrtc/modules/media_file/media_file_impl.cc b/webrtc/modules/media_file/media_file_impl.cc

index 27fe9613a3ba8ab8833a2b0833946262303aebdb..0672cfe82b8b1471ce95da1aa19f26c6cef5b028 100644

--- a/webrtc/modules/media_file/media_file_impl.cc

+++ b/webrtc/modules/media_file/media_file_impl.cc

@@ -371,12 +371,11 @@ int32_t MediaFileImpl::StartPlayingAudioFile(

return -1;

}

- if(inputStream->OpenFile(fileName, true, loop) != 0)

- {

- delete inputStream;

- WEBRTC_TRACE(kTraceError, kTraceFile, _id,

- "Could not open input file %s", fileName);

- return -1;

+ if (inputStream->OpenFile(fileName, true) != 0) {

+ delete inputStream;

+ WEBRTC_TRACE(kTraceError, kTraceFile, _id, "Could not open input file %s",

+ fileName);

+ return -1;

}

if(StartPlayingStream(*inputStream, loop, notificationTimeMs,