Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2053293002: Remove new fuzzers until their GN targets work properly in Chromium. (Closed)

Created:
4 years, 6 months ago by katrielc1
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kjellander_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove new fuzzers until their GN targets work properly in Chromium. Chromium uses gn gen --check, which doesn't like some of the includes used in the new gn targets the fuzzers use. This breaks Chromium libfuzzer compiles, for which there isn't yet a webrtc FYI bot. I'm working on fixing the includes, at which point these can come back. BUG=chromium:618901 NOTRY=true Committed: https://crrev.com/81ca73586ef1a0f7b9f904f965b42ce053056abb Cr-Commit-Position: refs/heads/master@{#13098}

Patch Set 1 #

Patch Set 2 : Oops, didn't mean to add new targets! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -103 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 1 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/test/fuzzers/sdp_parser_fuzzer.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D webrtc/test/fuzzers/stun_parser_fuzzer.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/test/fuzzers/stun_validator_fuzzer.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
katrielc
The gn targets that these use don't work with --check, causing https://bugs.chromium.org/p/chromium/issues/detail?id=618901. kjellander@ is working ...
4 years, 6 months ago (2016-06-10 09:51:51 UTC) #2
kjellander_webrtc
lgtm
4 years, 6 months ago (2016-06-10 09:55:01 UTC) #5
pbos-webrtc
lgtm
4 years, 6 months ago (2016-06-10 09:58:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053293002/20001
4 years, 6 months ago (2016-06-10 09:58:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 09:59:47 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 09:59:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81ca73586ef1a0f7b9f904f965b42ce053056abb
Cr-Commit-Position: refs/heads/master@{#13098}

Powered by Google App Engine
This is Rietveld 408576698