Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java

Issue 2053263002: Added a missing path separator that caused aecdump recordings not to be created in Android apprtc (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
diff --git a/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java b/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
index 94b66a769f51069a6388a3aba9cc34df58eed8fc..18f1470a53cfc684b29ca73762407b1b22373e8d 100644
--- a/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
+++ b/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
@@ -511,13 +511,12 @@ public class PeerConnectionClient {
if (peerConnectionParameters.aecDump) {
try {
- aecDumpFileDescriptor = ParcelFileDescriptor.open(
- new File(Environment.getExternalStorageDirectory().getPath()
- + "Download/audio.aecdump"),
- ParcelFileDescriptor.MODE_READ_WRITE |
- ParcelFileDescriptor.MODE_CREATE |
- ParcelFileDescriptor.MODE_TRUNCATE);
- factory.startAecDump(aecDumpFileDescriptor.getFd(), -1);
+ aecDumpFileDescriptor = ParcelFileDescriptor.open(
sakal 2016/06/10 07:27:41 Please use 2 space indentation instead of 4 space
+ new File(Environment.getExternalStorageDirectory().getPath() + File.separator
+ + "Download/audio.aecdump"),
+ ParcelFileDescriptor.MODE_READ_WRITE | ParcelFileDescriptor.MODE_CREATE
+ | ParcelFileDescriptor.MODE_TRUNCATE);
+ factory.startAecDump(aecDumpFileDescriptor.getFd(), -1);
} catch(IOException e) {
Log.e(TAG, "Can not open aecdump file", e);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698