Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java

Issue 2053263002: Added a missing path separator that caused aecdump recordings not to be created in Android apprtc (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Formatting changes according to reviewer comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2014 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 495 matching lines...) Expand 10 before | Expand all | Expand 10 after
506 mediaStream.addTrack(createVideoTrack(videoCapturer)); 506 mediaStream.addTrack(createVideoTrack(videoCapturer));
507 } 507 }
508 508
509 mediaStream.addTrack(createAudioTrack()); 509 mediaStream.addTrack(createAudioTrack());
510 peerConnection.addStream(mediaStream); 510 peerConnection.addStream(mediaStream);
511 511
512 if (peerConnectionParameters.aecDump) { 512 if (peerConnectionParameters.aecDump) {
513 try { 513 try {
514 aecDumpFileDescriptor = ParcelFileDescriptor.open( 514 aecDumpFileDescriptor = ParcelFileDescriptor.open(
515 new File(Environment.getExternalStorageDirectory().getPath() 515 new File(Environment.getExternalStorageDirectory().getPath()
516 + File.separator
516 + "Download/audio.aecdump"), 517 + "Download/audio.aecdump"),
517 ParcelFileDescriptor.MODE_READ_WRITE | 518 ParcelFileDescriptor.MODE_READ_WRITE |
518 ParcelFileDescriptor.MODE_CREATE | 519 ParcelFileDescriptor.MODE_CREATE |
519 ParcelFileDescriptor.MODE_TRUNCATE); 520 ParcelFileDescriptor.MODE_TRUNCATE);
520 factory.startAecDump(aecDumpFileDescriptor.getFd(), -1); 521 factory.startAecDump(aecDumpFileDescriptor.getFd(), -1);
521 } catch(IOException e) { 522 } catch(IOException e) {
522 Log.e(TAG, "Can not open aecdump file", e); 523 Log.e(TAG, "Can not open aecdump file", e);
523 } 524 }
524 } 525 }
525 526
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
1136 public void onCreateFailure(final String error) { 1137 public void onCreateFailure(final String error) {
1137 reportError("createSDP error: " + error); 1138 reportError("createSDP error: " + error);
1138 } 1139 }
1139 1140
1140 @Override 1141 @Override
1141 public void onSetFailure(final String error) { 1142 public void onSetFailure(final String error) {
1142 reportError("setSDP error: " + error); 1143 reportError("setSDP error: " + error);
1143 } 1144 }
1144 } 1145 }
1145 } 1146 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698