Update ICE role on all ports, not just ones used for new connections.

webrtc/p2p/base/p2ptransportchannel.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 101 matching lines @@
                  int flags) override;
   int SetOption(rtc::Socket::Option opt, int value) override;
   bool GetOption(rtc::Socket::Option opt, int* value) override;
   int GetError() override { return error_; }
   bool GetStats(std::vector<ConnectionInfo>* stats) override;
 
   const Connection* best_connection() const { return best_connection_; }
   void set_incoming_only(bool value) { incoming_only_ = value; }
 
   // Note: This is only for testing purpose.
-  // |ports_| should not be changed from outside.
-  const std::vector<PortInterface*>& ports() { return ports_; }
+  // |active_ports_| should not be changed from outside.
+  const std::vector<PortInterface*>& ports() { return active_ports_; }
 
   IceMode remote_ice_mode() const { return remote_ice_mode_; }
 
   // DTLS methods.
   bool IsDtlsActive() const override { return false; }
 
   // Default implementation.
   bool GetSslRole(rtc::SSLRole* role) const override { return false; }
 
   bool SetSslRole(rtc::SSLRole role) override { return false; }
@@ skipping 156 matching lines @@
     return remote_ice_parameters_.empty()
                ? 0
                : static_cast<uint32_t>(remote_ice_parameters_.size() - 1);
   }
 
   PortAllocator* allocator_;
   rtc::Thread* worker_thread_;
   bool incoming_only_;
   int error_;
   std::vector<std::unique_ptr<PortAllocatorSession>> allocator_sessions_;
-  std::vector<PortInterface *> ports_;
+  // |active_ports_| contains ports that are used to form new connections when
+  // new remote candidates are added.
+  std::vector<PortInterface*> active_ports_;
+  // |inactive_ports_| contains ports that aren't being used to form new
+  // connections, but that aren't yet destroyed. They may have existing
+  // connections, and they still fire signals such as SignalUnknownAddress.
+  std::vector<PortInterface*> inactive_ports_;

[pthatcher1, 2016/06/15 22:13:20]

For names, how about ports_ and removed_ports_waiting_to_be_destroyed_, with a
note that we keep the removed ports around so that we can change the role?

[Taylor Brandstetter, 2016/06/16 00:53:33]

I think removed_ports_ is sufficiently unambiguous. I'll include the rest of the
information in a comment.

 
   // |connections_| is a sorted list with the first one always be the
   // |best_connection_| when it's not nullptr. The combination of
   // |pinged_connections_| and |unpinged_connections_| has the same
   // connections as |connections_|. These 2 sets maintain whether a
   // connection should be pinged next or not.
   std::vector<Connection *> connections_;
   std::set<Connection*> pinged_connections_;
   std::set<Connection*> unpinged_connections_;
 
@@ skipping 21 matching lines @@
   TransportChannelState state_ = TransportChannelState::STATE_INIT;
   IceConfig config_;
   int last_sent_packet_id_ = -1;  // -1 indicates no packet was sent before.
 
   RTC_DISALLOW_COPY_AND_ASSIGN(P2PTransportChannel);
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_P2PTRANSPORTCHANNEL_H_