Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2052953002: Need relative paths in GN dependencies, or including in Chromium fails! (Closed)

Created:
4 years, 6 months ago by katrielc1
Modified:
4 years, 6 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Need relative paths in GN dependencies, or webrtc won't build in Chromium. BUG=chromium:618901 NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
katrielc
Oooops.
4 years, 6 months ago (2016-06-10 06:54:03 UTC) #4
phoglund
lgtm
4 years, 6 months ago (2016-06-10 07:16:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052953002/1
4 years, 6 months ago (2016-06-10 07:17:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6180)
4 years, 6 months ago (2016-06-10 07:19:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052953002/1
4 years, 6 months ago (2016-06-10 07:23:20 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 07:25:31 UTC) #16
Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6182)

Powered by Google App Engine
This is Rietveld 408576698