Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 2052233002: Enable passing receive stream ID to the decoder factory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Nit fixes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
index 111344f8c1d49b00dcc81297588fd66a94468e1d..03bdf235df558d7588fd70cf8974bb85fc4b2e3e 100644
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
@@ -822,6 +822,26 @@ class WebRtcVideoChannel2BaseTest
cricket::VideoCodec DefaultCodec() override { return kVp8Codec; }
};
+// Verifies that id given in stream params is passed to the decoder factory.
+TEST_F(WebRtcVideoEngine2Test, StreamParamsIdPassedToDecoderFactory) {
+ cricket::FakeWebRtcVideoDecoderFactory decoder_factory;
+ decoder_factory.AddSupportedVideoCodecType(webrtc::kVideoCodecVP8);
+ cricket::VideoRecvParameters parameters;
+ parameters.codecs.push_back(kVp8Codec);
+
+ std::unique_ptr<VideoMediaChannel> channel(
+ SetUpForExternalDecoderFactory(&decoder_factory, parameters.codecs));
+
+ StreamParams sp = cricket::StreamParams::CreateLegacy(kSsrc);
+ sp.id = "FakeStreamParamsId";
+ EXPECT_TRUE(channel->AddRecvStream(sp));
+ EXPECT_EQ(1u, decoder_factory.decoders().size());
+
+ std::vector<cricket::VideoDecoderParams> params = decoder_factory.params();
+ ASSERT_EQ(1u, params.size());
+ EXPECT_EQ(sp.id, params[0].receive_stream_id);
+}
+
#define WEBRTC_BASE_TEST(test) \
TEST_F(WebRtcVideoChannel2BaseTest, test) { Base::test(); }
@@ -3547,6 +3567,18 @@ TEST_F(WebRtcVideoChannel2Test, GetRtpReceiveParametersCodecs) {
EXPECT_EQ(kVp9Codec.ToCodecParameters(), rtp_parameters.codecs[1]);
}
+// Test that RtpParameters for receive stream has one encoding and it has
+// the correct SSRC.
+TEST_F(WebRtcVideoChannel2Test, RtpEncodingParametersSsrcIsSet) {
+ AddRecvStream();
+
+ webrtc::RtpParameters rtp_parameters =
+ channel_->GetRtpReceiveParameters(last_ssrc_);
+ ASSERT_EQ(1u, rtp_parameters.encodings.size());
+ EXPECT_EQ(rtc::Optional<uint32_t>(last_ssrc_),
+ rtp_parameters.encodings[0].ssrc);
+}
+
// Test that if we set/get parameters multiple times, we get the same results.
TEST_F(WebRtcVideoChannel2Test, SetAndGetRtpReceiveParameters) {
AddRecvStream();
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698