Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2051443002: Change name of files and class in agc/histogram* in order to avoid file-name clash. (Closed)

Created:
4 years, 6 months ago by peah-webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change name of files and class in agc/histogram* in order to avoid issue file-name clash in build files The changes are done in several patches in order to make the review easier. NOTRY=True BUG=webrtc:5949 Committed: https://crrev.com/bbe423312d9321e7de3144faba4198072338745a Cr-Commit-Position: refs/heads/master@{#13068}

Patch Set 1 : Changed file names and updated build files accordingly #

Patch Set 2 : Fixed include paths to reflect the new file names #

Patch Set 3 : Changed name of inclusion guard #

Patch Set 4 : Added missing include that cause CL upload warning #

Patch Set 5 : Ran gn format --in-place webrtc/modules/audio_processing/BUILD.gn #

Patch Set 6 : Changed name of the Histogram class to reflect what it actually does, and to match the new file name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -528 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc.cc View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download
D webrtc/modules/audio_processing/agc/histogram.h View 1 chunk +0 lines, -92 lines 0 comments Download
D webrtc/modules/audio_processing/agc/histogram.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D webrtc/modules/audio_processing/agc/histogram_unittest.cc View 1 chunk +0 lines, -105 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/loudness_histogram.h View 1 2 3 4 5 5 chunks +14 lines, -14 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/loudness_histogram.cc View 1 2 3 4 5 11 chunks +53 lines, -53 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/loudness_histogram_unittest.cc View 1 2 3 4 5 3 chunks +22 lines, -21 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/agc/activity_metric.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
peah-webrtc
4 years, 6 months ago (2016-06-08 12:58:18 UTC) #5
kjellander_webrtc
lgtm Please run a few compile-trybots just to be sure and add NOTRY=True to make ...
4 years, 6 months ago (2016-06-08 13:02:03 UTC) #6
kjellander_webrtc
On 2016/06/08 13:02:03, kjellander_webrtc wrote: > lgtm > > Please run a few compile-trybots just ...
4 years, 6 months ago (2016-06-08 13:02:54 UTC) #8
peah-webrtc
On 2016/06/08 13:02:54, kjellander_webrtc wrote: > On 2016/06/08 13:02:03, kjellander_webrtc wrote: > > lgtm > ...
4 years, 6 months ago (2016-06-08 13:13:20 UTC) #9
hlundin-webrtc
lgtm
4 years, 6 months ago (2016-06-08 13:24:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051443002/120001
4 years, 6 months ago (2016-06-08 13:34:47 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 6 months ago (2016-06-08 13:42:08 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 13:42:12 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/bbe423312d9321e7de3144faba4198072338745a
Cr-Commit-Position: refs/heads/master@{#13068}

Powered by Google App Engine
This is Rietveld 408576698