Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2051413003: GN: Add rtc_pc_unittests (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Add rtc_pc_unittests BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. NOTRY=True TBR=perkj@webrtc.org Committed: https://crrev.com/142f8c5b3bf9ace8d9c6bad21fb52ce3b9615270 Cr-Commit-Position: refs/heads/master@{#13107}

Patch Set 1 #

Patch Set 2 : Fix win warning config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
M webrtc/pc/BUILD.gn View 1 2 chunks +60 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
kjellander_webrtc
TBR since this is so straightforward.
4 years, 6 months ago (2016-06-13 07:02:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051413003/40001
4 years, 6 months ago (2016-06-13 07:03:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-13 07:08:29 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 07:08:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/142f8c5b3bf9ace8d9c6bad21fb52ce3b9615270
Cr-Commit-Position: refs/heads/master@{#13107}

Powered by Google App Engine
This is Rietveld 408576698