GN: Add rtc_media_unittests

GN: Add rtc_media_unittests

Changes:
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope
  to match GYP.
* Enable sctpdataengine_unittest.cc for iOS, which should have
  been done in https://codereview.webrtc.org/1587193006
* Renamed GN target rtc_base_test_utils -> rtc_base_tests_utils
  to match GYP.
* Added dependencies on call, modules/video_coding and video for
  rtc_media.
* Added dependency on audio for rtc_media_unitttests (couldn't be
  added to rtc_media due to circular dependency problem).

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True

Committed: https://crrev.com/82a94494b1fc211a9b9e0256fc207b012357f191
Cr-Commit-Position: refs/heads/master@{#13106}

[kjellander_webrtc, 2016-06-09 17:26:52]

Description was changed from

==========
GN: Add rtc_media_unittests

Changes:
* Enable sctpdataengine_unittest.cc for iOS, which should have
  been done in https://codereview.webrtc.org/1587193006
* Renamed GN target rtc_base_test_utils -> rtc_base_tests_utils
  to match GYP.
* Added dependencies on call, modules/video_coding and video for
  rtc_media.
* Added dependency on audio for rtc_media_unitttests (couldn't be
  added to rtc_media due to circular dependency problem).

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
==========

to

==========
GN: Add rtc_media_unittests

Changes:
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope
  to match GYP.
* Enable sctpdataengine_unittest.cc for iOS, which should have
  been done in https://codereview.webrtc.org/1587193006
* Renamed GN target rtc_base_test_utils -> rtc_base_tests_utils
  to match GYP.
* Added dependencies on call, modules/video_coding and video for
  rtc_media.
* Added dependency on audio for rtc_media_unitttests (couldn't be
  added to rtc_media due to circular dependency problem).

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
==========

[kjellander_webrtc, 2016-06-09 17:33:37]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-06-10 09:14:08]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-06-10 09:14:15]

Patchset #1 (id:40001) has been deleted

[kjellander_webrtc, 2016-06-10 09:23:10]

Patchset #2 (id:80001) has been deleted

[kjellander_webrtc, 2016-06-10 09:33:32]

kjellander@webrtc.org changed reviewers:
+ perkj@webrtc.org

[kjellander_webrtc, 2016-06-10 09:33:33]

https://codereview.webrtc.org/2050313002/diff/60001/webrtc/media/BUILD.gn
File webrtc/media/BUILD.gn (left):

https://codereview.webrtc.org/2050313002/diff/60001/webrtc/media/BUILD.gn#old...
webrtc/media/BUILD.gn:164: configs += [ ":rtc_media_defines_config" ]
(since already present as public_configs, this doesn't do anything)

https://codereview.webrtc.org/2050313002/diff/60001/webrtc/media/media.gyp
File webrtc/media/media.gyp (left):

https://codereview.webrtc.org/2050313002/diff/60001/webrtc/media/media.gyp#ol...
webrtc/media/media.gyp:329: 'sctp/sctpdataengine_unittest.cc',
This is a leftover from when sctp/sctpdataengine.cc was excluded for rtc_media
target on iOS a while back. Since it's now enabled we should also enable the
unit test.

[perkj_webrtc, 2016-06-10 11:42:25]

On 2016/06/10 09:33:33, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2050313002/diff/60001/webrtc/media/BUILD.gn
> File webrtc/media/BUILD.gn (left):
> 
>
https://codereview.webrtc.org/2050313002/diff/60001/webrtc/media/BUILD.gn#old...
> webrtc/media/BUILD.gn:164: configs += [ ":rtc_media_defines_config" ]
> (since already present as public_configs, this doesn't do anything)
> 
> https://codereview.webrtc.org/2050313002/diff/60001/webrtc/media/media.gyp
> File webrtc/media/media.gyp (left):
> 
>
https://codereview.webrtc.org/2050313002/diff/60001/webrtc/media/media.gyp#ol...
> webrtc/media/media.gyp:329: 'sctp/sctpdataengine_unittest.cc',
> This is a leftover from when sctp/sctpdataengine.cc was excluded for rtc_media
> target on iOS a while back. Since it's now enabled we should also enable the
> unit test.

lgtm

[kjellander_webrtc, 2016-06-10 11:55:26]

Patchset #3 (id:120001) has been deleted

[kjellander_webrtc, 2016-06-10 20:49:13]

Patchset #3 (id:140001) has been deleted

[kjellander_webrtc, 2016-06-13 05:06:46]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-06-13 05:06:47]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2050313002/#ps160001 (title:
"Updated after https://codereview.webrtc.org/2024813004")

[commit-bot: I haz the power, 2016-06-13 05:06:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050313002/160001

[kjellander_webrtc, 2016-06-13 05:07:06]

The CQ bit was unchecked by kjellander@webrtc.org

[kjellander_webrtc, 2016-06-13 05:07:55]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-06-13 05:08:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050313002/160001

[commit-bot: I haz the power, 2016-06-13 05:12:07]

Description was changed from

==========
GN: Add rtc_media_unittests

Changes:
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope
  to match GYP.
* Enable sctpdataengine_unittest.cc for iOS, which should have
  been done in https://codereview.webrtc.org/1587193006
* Renamed GN target rtc_base_test_utils -> rtc_base_tests_utils
  to match GYP.
* Added dependencies on call, modules/video_coding and video for
  rtc_media.
* Added dependency on audio for rtc_media_unitttests (couldn't be
  added to rtc_media due to circular dependency problem).

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
==========

to

==========
GN: Add rtc_media_unittests

Changes:
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope
  to match GYP.
* Enable sctpdataengine_unittest.cc for iOS, which should have
  been done in https://codereview.webrtc.org/1587193006
* Renamed GN target rtc_base_test_utils -> rtc_base_tests_utils
  to match GYP.
* Added dependencies on call, modules/video_coding and video for
  rtc_media.
* Added dependency on audio for rtc_media_unitttests (couldn't be
  added to rtc_media due to circular dependency problem).

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
==========

[commit-bot: I haz the power, 2016-06-13 05:12:08]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2016-06-13 05:12:09]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 05:12:20]

Description was changed from

==========
GN: Add rtc_media_unittests

Changes:
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope
  to match GYP.
* Enable sctpdataengine_unittest.cc for iOS, which should have
  been done in https://codereview.webrtc.org/1587193006
* Renamed GN target rtc_base_test_utils -> rtc_base_tests_utils
  to match GYP.
* Added dependencies on call, modules/video_coding and video for
  rtc_media.
* Added dependency on audio for rtc_media_unitttests (couldn't be
  added to rtc_media due to circular dependency problem).

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
==========

to

==========
GN: Add rtc_media_unittests

Changes:
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global scope
  to match GYP.
* Enable sctpdataengine_unittest.cc for iOS, which should have
  been done in https://codereview.webrtc.org/1587193006
* Renamed GN target rtc_base_test_utils -> rtc_base_tests_utils
  to match GYP.
* Added dependencies on call, modules/video_coding and video for
  rtc_media.
* Added dependency on audio for rtc_media_unitttests (couldn't be
  added to rtc_media due to circular dependency problem).

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True

Committed: https://crrev.com/82a94494b1fc211a9b9e0256fc207b012357f191
Cr-Commit-Position: refs/heads/master@{#13106}
==========

[commit-bot: I haz the power, 2016-06-13 05:12:21]

Patchset 3 (id:??) landed as
https://crrev.com/82a94494b1fc211a9b9e0256fc207b012357f191
Cr-Commit-Position: refs/heads/master@{#13106}