Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2050273002:
Remove unnecessary redefinition of PacketLists in rtp_fec_unittest. (Closed)
|
Created:
4 years, 6 months ago by brandtr Modified:
4 years, 6 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove unnecessary redefinition of PacketLists in rtp_fec_unittest.
R=stefan@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/be99ab93564f67d18c7a651639387e9238fb9ae9
Patch Set 1 #
Messages
Total messages: 23 (12 generated)
Description was changed from ========== Fix unnecessary redefinition of PacketLists in rtp_fec_unittest. ========== to ========== Remove unnecessary redefinition of PacketLists in rtp_fec_unittest. ==========
brandtr@webrtc.org changed reviewers: + stefan@webrtc.org
Trivial change just to get the ball rolling for me w.r.t. submitting CLs.
lgtm
The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050273002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14051)
The CQ bit was checked by brandtr@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050273002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14060)
The CQ bit was checked by brandtr@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050273002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14074)
The CQ bit was checked by brandtr@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050273002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14110)
Description was changed from ========== Remove unnecessary redefinition of PacketLists in rtp_fec_unittest. ========== to ========== Remove unnecessary redefinition of PacketLists in rtp_fec_unittest. R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/be99ab93564f67d18c7a65163... ==========
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary redefinition of PacketLists in rtp_fec_unittest. R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/be99ab93564f67d18c7a65163... ========== to ========== Remove unnecessary redefinition of PacketLists in rtp_fec_unittest. R=stefan@webrtc.org Committed: https://crrev.com/be99ab93564f67d18c7a651639387e9238fb9ae9 Cr-Commit-Position: refs/heads/master@{#13109} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as be99ab93564f67d18c7a651639387e9238fb9ae9 (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
