Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2049933004:
Report errors creating peer connection in AppRTC Demo Android. (Closed)
|
Created:
4 years, 6 months ago by sakal Modified:
4 years, 6 months ago Reviewers:
perkj_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReport errors creating peer connection in AppRTC Demo Android.
Right now if an exception is thrown, it doesn't seem to be logged
anywhere. This CL makes it show a pop-up with the error message.
This should save time debugging issues.
Committed: https://crrev.com/54f5a2642135da29fcdb5c9d10417a87778321f4
Cr-Commit-Position: refs/heads/master@{#13120}
Patch Set 1 #Patch Set 2 : Fix grammar mistake #Messages
Total messages: 35 (18 generated)
Description was changed from ========== Report errors creating peer connection in AppRTC Demo Android. Right now if an exception is thrown, it doesn't seem to be logged anywhere. This CL makes it show a pop-up with the error message. This should save time debugging issues. ========== to ========== Report errors creating peer connection in AppRTC Demo Android. Right now if an exception is thrown, it doesn't seem to be logged anywhere. This CL makes it show a pop-up with the error message. This should save time debugging issues. ==========
sakal@webrtc.org changed reviewers: + perkj@webrtc.org
Per, please take a look.
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933004/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by sakal@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org Link to the patchset: https://codereview.webrtc.org/2049933004/#ps20001 (title: "Fix grammar mistake")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14045)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14065)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14069)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14115)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14127)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933004/20001
Message was sent while issue was closed.
Description was changed from ========== Report errors creating peer connection in AppRTC Demo Android. Right now if an exception is thrown, it doesn't seem to be logged anywhere. This CL makes it show a pop-up with the error message. This should save time debugging issues. ========== to ========== Report errors creating peer connection in AppRTC Demo Android. Right now if an exception is thrown, it doesn't seem to be logged anywhere. This CL makes it show a pop-up with the error message. This should save time debugging issues. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Report errors creating peer connection in AppRTC Demo Android. Right now if an exception is thrown, it doesn't seem to be logged anywhere. This CL makes it show a pop-up with the error message. This should save time debugging issues. ========== to ========== Report errors creating peer connection in AppRTC Demo Android. Right now if an exception is thrown, it doesn't seem to be logged anywhere. This CL makes it show a pop-up with the error message. This should save time debugging issues. Committed: https://crrev.com/54f5a2642135da29fcdb5c9d10417a87778321f4 Cr-Commit-Position: refs/heads/master@{#13120} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/54f5a2642135da29fcdb5c9d10417a87778321f4 Cr-Commit-Position: refs/heads/master@{#13120} |
