Issue 2049153002: Use the new versions of OnAddStream/OnRemoveStream in objc binding.

Issue 2049153002: Use the new versions of OnAddStream/OnRemoveStream in objc binding. (Closed)

Created:
4 years, 6 months ago by Taylor Brandstetter

Modified:
4 years, 6 months ago

Reviewers:
tkchin_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Use the new versions of OnAddStream/OnRemoveStream in objc binding. Committed: https://crrev.com/d5f41ce89899abf47cd015ccc52524d467e0eb44 Cr-Commit-Position: refs/heads/master@{#13078}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Private.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 8 (3 generated)

Taylor Brandstetter

Zeke, PTAL. I'm just changing these methods to take a scoped_refptr argument, to make it ...

4 years, 6 months ago (2016-06-08 18:05:47 UTC) #2

tkchin_webrtc

On 2016/06/08 18:05:47, Taylor Brandstetter wrote: > Zeke, PTAL. I'm just changing these methods to ...

4 years, 6 months ago (2016-06-08 19:40:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049153002/1

4 years, 6 months ago (2016-06-08 19:40:34 UTC) #5

commit-bot: I haz the power

4 years, 6 months ago (2016-06-08 20:31:57 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d5f41ce89899abf47cd015ccc52524d467e0eb44
Cr-Commit-Position: refs/heads/master@{#13078}