Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2049023002: Revert of New static method I420Buffer::SetToBlack. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of New static method I420Buffer::SetToBlack. (patchset #4 id:60001 of https://codereview.webrtc.org/2029273004/ ) Reason for revert: Breaks chrome, in particular, the tests in media_stream_remote_video_source_unittest.cc use the InitToBlack method which is being deleted. Original issue's description: > New static method I420Buffer::SetToBlack. > > Replaces cricket::VideoFrame::SetToBlack and > cricket::WebRtcVideoFrame::InitToBlack, which are deleted. > > Refactors the black frame logic in VideoBroadcaster, and a few of the > tests. > > BUG=webrtc:5682 > > Committed: https://crrev.com/663f9e2ddc86e813f6db04ba2cf5ac1ed9e7ef67 > Cr-Commit-Position: refs/heads/master@{#13063} TBR=perkj@webrtc.org,pbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/271d74078894bb24f454eb31b77e4ce38097a2fa Cr-Commit-Position: refs/heads/master@{#13065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -160 lines) Patch
M webrtc/common_video/include/video_frame_buffer.h View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/common_video/video_frame_buffer.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/media/base/fakevideorenderer.h View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/media/base/videobroadcaster.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/media/base/videobroadcaster.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/media/base/videoframe.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 15 chunks +90 lines, -99 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-webrtc
Created Revert of New static method I420Buffer::SetToBlack.
4 years, 6 months ago (2016-06-08 12:20:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049023002/1
4 years, 6 months ago (2016-06-08 12:20:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 12:20:58 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/271d74078894bb24f454eb31b77e4ce38097a2fa Cr-Commit-Position: refs/heads/master@{#13065}
4 years, 6 months ago (2016-06-08 12:21:11 UTC) #7
nisse-webrtc
4 years, 6 months ago (2016-06-08 13:52:57 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2049513005/ by nisse@webrtc.org.

The reason for reverting is: Plan to reland with InitToBlack kept, to be able to
update Chrome to use the new I420Buffer::SetToBlack method..

Powered by Google App Engine
This is Rietveld 408576698