Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: webrtc/media/engine/fakewebrtccall.cc

Issue 2047513002: Add proper lifetime of encoder-specific settings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/fakewebrtccall.cc
diff --git a/webrtc/media/engine/fakewebrtccall.cc b/webrtc/media/engine/fakewebrtccall.cc
index fdf7cf36fc4bb678d09d9dc6a66c00a2c24a9d8f..73b2df5755f9c65cd01f5e5e163197f0141b8e8e 100644
--- a/webrtc/media/engine/fakewebrtccall.cc
+++ b/webrtc/media/engine/fakewebrtccall.cc
@@ -181,15 +181,13 @@ void FakeVideoSendStream::ReconfigureVideoEncoder(
encoder_config_ = config;
if (config.encoder_specific_settings != NULL) {
if (config_.encoder_settings.payload_name == "VP8") {
- vpx_settings_.vp8 = *reinterpret_cast<const webrtc::VideoCodecVP8*>(
- config.encoder_specific_settings);
+ config.encoder_specific_settings->FillVideoCodecVp8(&vpx_settings_.vp8);
if (!config.streams.empty()) {
vpx_settings_.vp8.numberOfTemporalLayers = static_cast<unsigned char>(
config.streams.back().temporal_layer_thresholds_bps.size() + 1);
}
} else if (config_.encoder_settings.payload_name == "VP9") {
- vpx_settings_.vp9 = *reinterpret_cast<const webrtc::VideoCodecVP9*>(
- config.encoder_specific_settings);
+ config.encoder_specific_settings->FillVideoCodecVp9(&vpx_settings_.vp9);
if (!config.streams.empty()) {
vpx_settings_.vp9.numberOfTemporalLayers = static_cast<unsigned char>(
config.streams.back().temporal_layer_thresholds_bps.size() + 1);

Powered by Google App Engine
This is Rietveld 408576698