Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: webrtc/call/call_perf_tests.cc

Issue 2046943004: Changes synchronization offset perfomance tracking (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call_perf_tests.cc
diff --git a/webrtc/call/call_perf_tests.cc b/webrtc/call/call_perf_tests.cc
index 50e1a62cfb512f10a0b47f93c25631b3906c42af..aa2264f1550c0f758344da099a1eea77f0dc4855 100644
--- a/webrtc/call/call_perf_tests.cc
+++ b/webrtc/call/call_perf_tests.cc
@@ -98,8 +98,6 @@ class VideoRtcpAndSyncObserver : public test::RtpRtcpObserver,
return;
int64_t now_ms = clock_->TimeInMilliseconds();
-
- sync_offset_ms_list_.push_back(stats.sync_offset_ms);
stefan-webrtc 2016/06/08 11:02:25 Maybe we should still track this, but track it onl
danilchap 2016/06/08 11:25:16 yes, that make sense (I missed the fact that test
int64_t time_since_creation = now_ms - creation_time_ms_;
// During the first couple of seconds audio and video can falsely be
// estimated as being synchronized. We don't want to trigger on those.
@@ -125,19 +123,12 @@ class VideoRtcpAndSyncObserver : public test::RtpRtcpObserver,
receive_stream_ = receive_stream;
}
- void PrintResults() {
- test::PrintResultList("stream_offset", "", "synchronization",
- test::ValuesToString(sync_offset_ms_list_), "ms",
- false);
- }
-
private:
Clock* const clock_;
const int64_t creation_time_ms_;
int64_t first_time_in_sync_;
rtc::CriticalSection crit_;
VideoReceiveStream* receive_stream_ GUARDED_BY(crit_);
- std::vector<int> sync_offset_ms_list_;
};
void CallPerfTest::TestAudioVideoSync(FecMode fec,
@@ -299,7 +290,6 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec,
VoiceEngine::Delete(voice_engine);
- observer.PrintResults();
EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.AVSyncOffsetInMs"));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698