Chromium Code Reviews| Index: webrtc/api/remoteaudiosource.h |
| diff --git a/webrtc/api/remoteaudiosource.h b/webrtc/api/remoteaudiosource.h |
| index abb55f62a768442eb0c8935499fe4f8c241df7b2..4cc68f8047fd85167b27370371d09b191a0cfb95 100644 |
| --- a/webrtc/api/remoteaudiosource.h |
| +++ b/webrtc/api/remoteaudiosource.h |
| @@ -14,10 +14,10 @@ |
| #include <list> |
| #include <string> |
| -#include "webrtc/api/mediastreaminterface.h" |
| #include "webrtc/api/notifier.h" |
| #include "webrtc/audio_sink.h" |
| #include "webrtc/base/criticalsection.h" |
| +#include "webrtc/pc/channel.h" |
| namespace rtc { |
| struct Message; |
| @@ -26,15 +26,13 @@ class Thread; |
| namespace webrtc { |
| -class AudioProviderInterface; |
| - |
| // This class implements the audio source used by the remote audio track. |
| class RemoteAudioSource : public Notifier<AudioSourceInterface> { |
|
pthatcher1
2016/06/21 07:45:41
It sounds like this should be in pc/, not api/.
Taylor Brandstetter
2016/06/22 00:50:17
Yep. Same with most things currently in /api/.
|
| public: |
| // Creates an instance of RemoteAudioSource. |
| static rtc::scoped_refptr<RemoteAudioSource> Create( |
| uint32_t ssrc, |
| - AudioProviderInterface* provider); |
| + cricket::VoiceChannel* channel); |
|
pthatcher1
2016/06/21 07:45:41
Could this take an RtpReceiver instead?
Taylor Brandstetter
2016/06/22 00:50:17
I agree some refactoring is in order here, but I d
|
| // MediaSourceInterface implementation. |
| MediaSourceInterface::SourceState state() const override; |
| @@ -49,7 +47,7 @@ class RemoteAudioSource : public Notifier<AudioSourceInterface> { |
| // Post construction initialize where we can do things like save a reference |
| // to ourselves (need to be fully constructed). |
| - void Initialize(uint32_t ssrc, AudioProviderInterface* provider); |
| + void Initialize(uint32_t ssrc, cricket::VoiceChannel* channel); |
| private: |
| typedef std::list<AudioObserver*> AudioObserverList; |
| @@ -61,7 +59,7 @@ class RemoteAudioSource : public Notifier<AudioSourceInterface> { |
| class Sink; |
| void OnData(const AudioSinkInterface::Data& audio); |
| - void OnAudioProviderGone(); |
| + void OnAudioChannelGone(); |
| class MessageHandler; |
| void OnMessage(rtc::Message* msg); |