Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: webrtc/api/webrtcsession.cc

Issue 2046173002: Use VoiceChannel/VideoChannel directly from RtpSender/RtpReceiver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/webrtcsession.cc
diff --git a/webrtc/api/webrtcsession.cc b/webrtc/api/webrtcsession.cc
index a7c712c6a1f8c407f74d41992aeb6def83cf8634..9801d58f174939ded34c1fdd99261f798cb21e4d 100644
--- a/webrtc/api/webrtcsession.cc
+++ b/webrtc/api/webrtcsession.cc
@@ -1169,161 +1169,6 @@ std::string WebRtcSession::BadStateErrMsg(State state) {
return desc.str();
}
-void WebRtcSession::SetAudioPlayout(uint32_t ssrc, bool enable) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!voice_channel_) {
- LOG(LS_ERROR) << "SetAudioPlayout: No audio channel exists.";
- return;
- }
- if (!voice_channel_->SetOutputVolume(ssrc, enable ? 1 : 0)) {
- // Allow that SetOutputVolume fail if |enable| is false but assert
- // otherwise. This in the normal case when the underlying media channel has
- // already been deleted.
- ASSERT(enable == false);
- }
-}
-
-void WebRtcSession::SetAudioSend(uint32_t ssrc,
- bool enable,
- const cricket::AudioOptions& options,
- cricket::AudioSource* source) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!voice_channel_) {
- LOG(LS_ERROR) << "SetAudioSend: No audio channel exists.";
- return;
- }
- if (!voice_channel_->SetAudioSend(ssrc, enable, &options, source)) {
- LOG(LS_ERROR) << "SetAudioSend: ssrc is incorrect: " << ssrc;
- }
-}
-
-void WebRtcSession::SetAudioPlayoutVolume(uint32_t ssrc, double volume) {
- ASSERT(signaling_thread()->IsCurrent());
- ASSERT(volume >= 0 && volume <= 10);
- if (!voice_channel_) {
- LOG(LS_ERROR) << "SetAudioPlayoutVolume: No audio channel exists.";
- return;
- }
-
- if (!voice_channel_->SetOutputVolume(ssrc, volume)) {
- ASSERT(false);
- }
-}
-
-void WebRtcSession::SetRawAudioSink(uint32_t ssrc,
- std::unique_ptr<AudioSinkInterface> sink) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!voice_channel_)
- return;
-
- voice_channel_->SetRawAudioSink(ssrc, std::move(sink));
-}
-
-RtpParameters WebRtcSession::GetAudioRtpSendParameters(uint32_t ssrc) const {
- ASSERT(signaling_thread()->IsCurrent());
- if (voice_channel_) {
- return voice_channel_->GetRtpSendParameters(ssrc);
- }
- return RtpParameters();
-}
-
-bool WebRtcSession::SetAudioRtpSendParameters(uint32_t ssrc,
- const RtpParameters& parameters) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!voice_channel_) {
- return false;
- }
- return voice_channel_->SetRtpSendParameters(ssrc, parameters);
-}
-
-RtpParameters WebRtcSession::GetAudioRtpReceiveParameters(uint32_t ssrc) const {
- ASSERT(signaling_thread()->IsCurrent());
- if (voice_channel_) {
- return voice_channel_->GetRtpReceiveParameters(ssrc);
- }
- return RtpParameters();
-}
-
-bool WebRtcSession::SetAudioRtpReceiveParameters(
- uint32_t ssrc,
- const RtpParameters& parameters) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!voice_channel_) {
- return false;
- }
- return voice_channel_->SetRtpReceiveParameters(ssrc, parameters);
-}
-
-void WebRtcSession::SetVideoPlayout(
- uint32_t ssrc,
- bool enable,
- rtc::VideoSinkInterface<cricket::VideoFrame>* sink) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!video_channel_) {
- LOG(LS_WARNING) << "SetVideoPlayout: No video channel exists.";
- return;
- }
- if (!video_channel_->SetSink(ssrc, enable ? sink : NULL)) {
- // Allow that SetSink fail if |sink| is NULL but assert otherwise.
- // This in the normal case when the underlying media channel has already
- // been deleted.
- ASSERT(sink == NULL);
- }
-}
-
-void WebRtcSession::SetVideoSend(
- uint32_t ssrc,
- bool enable,
- const cricket::VideoOptions* options,
- rtc::VideoSourceInterface<cricket::VideoFrame>* source) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!video_channel_) {
- LOG(LS_WARNING) << "SetVideoSend: No video channel exists.";
- return;
- }
- if (!video_channel_->SetVideoSend(ssrc, enable, options, source)) {
- // Allow that MuteStream fail if |enable| is false and |source| is NULL but
- // assert otherwise. This in the normal case when the underlying media
- // channel has already been deleted.
- ASSERT(enable == false && source == nullptr);
- }
-}
-
-RtpParameters WebRtcSession::GetVideoRtpSendParameters(uint32_t ssrc) const {
- ASSERT(signaling_thread()->IsCurrent());
- if (video_channel_) {
- return video_channel_->GetRtpSendParameters(ssrc);
- }
- return RtpParameters();
-}
-
-bool WebRtcSession::SetVideoRtpSendParameters(uint32_t ssrc,
- const RtpParameters& parameters) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!video_channel_) {
- return false;
- }
- return video_channel_->SetRtpSendParameters(ssrc, parameters);
-}
-
-RtpParameters WebRtcSession::GetVideoRtpReceiveParameters(uint32_t ssrc) const {
- ASSERT(signaling_thread()->IsCurrent());
- if (video_channel_) {
- return video_channel_->GetRtpReceiveParameters(ssrc);
- }
- return RtpParameters();
-}
-
-bool WebRtcSession::SetVideoRtpReceiveParameters(
- uint32_t ssrc,
- const RtpParameters& parameters) {
- ASSERT(signaling_thread()->IsCurrent());
- if (!video_channel_) {
- return false;
- }
- return video_channel_->SetRtpReceiveParameters(ssrc, parameters);
-}
-
bool WebRtcSession::CanInsertDtmf(const std::string& track_id) {
ASSERT(signaling_thread()->IsCurrent());
if (!voice_channel_) {

Powered by Google App Engine
This is Rietveld 408576698