Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2046123003: Don't re-determine ICE role on an ICE restart. (Closed)

Created:
4 years, 6 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1, honghaiz3
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't re-determine ICE role on an ICE restart. This only causes an increased likelihood of role conflicts as each peer is picking a new role. It also means that if ICE is restarted for only one media stream, roles can be different across media streams (which isn't even allowed). For more explanation of why this is unnecessary and should be changed, see this discussion: https://mailarchive.ietf.org/arch/msg/ice/C0_QRCTNcwtvUF12y28jQicPR10 Committed: https://crrev.com/73fbcf9237b1109283ef590b24188b1d64144358 Cr-Commit-Position: refs/heads/master@{#13077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M webrtc/p2p/base/transport.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 3 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
4 years, 6 months ago (2016-06-07 23:28:38 UTC) #2
pthatcher1
lgtm That was quick.
4 years, 6 months ago (2016-06-08 19:21:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046123003/1
4 years, 6 months ago (2016-06-08 19:37:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 20:13:03 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:13:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73fbcf9237b1109283ef590b24188b1d64144358
Cr-Commit-Position: refs/heads/master@{#13077}

Powered by Google App Engine
This is Rietveld 408576698