Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2045733005: Hide *.xcworkspace files (Closed)

Created:
4 years, 6 months ago by afedor
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, kjellander_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Hide *.xcworkspace files For hiding xcworkspace files, along with xcodeproj files, both of which are created by the ninja xcode generator BUG=NONE NOTRY=True Committed: https://crrev.com/1c76bf1fbe804e9f2c94e1d84f8f665b0c62107c Cr-Commit-Position: refs/heads/master@{#13075}

Patch Set 1 #

Patch Set 2 : Remo name from AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
afedor
4 years, 6 months ago (2016-06-08 14:22:32 UTC) #3
henrika_webrtc
Thanks but please remove your name from the AUTHORS file until a more valid change ...
4 years, 6 months ago (2016-06-08 14:40:01 UTC) #5
afedor
Removed myself from AUTHORS
4 years, 6 months ago (2016-06-08 15:02:51 UTC) #6
kjellander_webrtc
lgtm
4 years, 6 months ago (2016-06-08 19:21:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045733005/20001
4 years, 6 months ago (2016-06-08 19:21:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 19:23:28 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 19:23:31 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c76bf1fbe804e9f2c94e1d84f8f665b0c62107c
Cr-Commit-Position: refs/heads/master@{#13075}

Powered by Google App Engine
This is Rietveld 408576698