Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2045203003: Disable flaky TurnPortTests on Memcheck. (Closed)

Created:
4 years, 6 months ago by åsapersson
Modified:
4 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
åsapersson
4 years, 6 months ago (2016-06-08 14:38:10 UTC) #3
kjellander_webrtc
I think we should make it wider to be sure. I added NOTRY=True to this ...
4 years, 6 months ago (2016-06-08 14:42:06 UTC) #5
åsapersson
https://codereview.webrtc.org/2045203003/diff/1/tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt File tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt (right): https://codereview.webrtc.org/2045203003/diff/1/tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt#newcode15 tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt:15: TurnPortTest.TestTurnSendDataTurnTcpToUdp On 2016/06/08 14:42:06, kjellander_webrtc wrote: > Let's do ...
4 years, 6 months ago (2016-06-08 14:44:41 UTC) #6
kjellander_webrtc
lgtm
4 years, 6 months ago (2016-06-08 14:55:07 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b6439396bfe684003fd297c06cad81f70d461790 Cr-Commit-Position: refs/heads/master@{#13071}
4 years, 6 months ago (2016-06-08 14:57:45 UTC) #9
åsapersson
4 years, 6 months ago (2016-06-08 14:57:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b6439396bfe684003fd297c06cad81f70d461790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698