Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2044703007: Delete unused YuvFrameGenerator class. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused YuvFrameGenerator class. NOTRY=True # android_arm64_rel bot not cooperating BUG= Committed: https://crrev.com/bdce06e460d3b22df1a7208afd0b826c715bace7 Cr-Commit-Position: refs/heads/master@{#13100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -375 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/media/base/yuvframegenerator.h View 1 chunk +0 lines, -94 lines 0 comments Download
D webrtc/media/base/yuvframegenerator.cc View 1 chunk +0 lines, -277 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
nisse-webrtc
This very nice class appears to be totally unused.
4 years, 6 months ago (2016-06-09 12:24:15 UTC) #2
pbos-webrtc
neat, lgtm, make sure it's not built into Chromium before landing
4 years, 6 months ago (2016-06-09 12:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044703007/1
4 years, 6 months ago (2016-06-09 12:55:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8549)
4 years, 6 months ago (2016-06-09 13:05:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044703007/1
4 years, 6 months ago (2016-06-09 13:12:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8551)
4 years, 6 months ago (2016-06-09 13:21:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044703007/1
4 years, 6 months ago (2016-06-09 13:23:42 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8557)
4 years, 6 months ago (2016-06-09 13:54:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044703007/1
4 years, 6 months ago (2016-06-10 08:48:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8585)
4 years, 6 months ago (2016-06-10 09:21:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044703007/1
4 years, 6 months ago (2016-06-10 11:42:12 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 11:43:53 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 11:43:55 UTC) #25
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 11:44:01 UTC) #27
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bdce06e460d3b22df1a7208afd0b826c715bace7
Cr-Commit-Position: refs/heads/master@{#13100}

Powered by Google App Engine
This is Rietveld 408576698