Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2042603002: Movable support for VideoReceiveStream::Config and avoid copies (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoengine2.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc
index c6e99689985b06f4ad0d8a6f3b3525ec5bdbcd2d..54d0b324b18836966bd6e622f11086431693938c 100644
--- a/webrtc/media/engine/webrtcvideoengine2.cc
+++ b/webrtc/media/engine/webrtcvideoengine2.cc
@@ -1227,7 +1227,7 @@ bool WebRtcVideoChannel2::AddRecvStream(const StreamParams& sp,
video_config_.disable_prerenderer_smoothing;
receive_streams_[ssrc] = new WebRtcVideoReceiveStream(
- call_, sp, config, external_decoder_factory_, default_stream,
+ call_, sp, std::move(config), external_decoder_factory_, default_stream,
recv_codecs_, red_disabled_by_remote_side_);
return true;
@@ -2197,7 +2197,7 @@ void WebRtcVideoChannel2::WebRtcVideoSendStream::RecreateWebRtcStream() {
WebRtcVideoChannel2::WebRtcVideoReceiveStream::WebRtcVideoReceiveStream(
webrtc::Call* call,
const StreamParams& sp,
- const webrtc::VideoReceiveStream::Config& config,
+ webrtc::VideoReceiveStream::Config config,
WebRtcVideoDecoderFactory* external_decoder_factory,
bool default_stream,
const std::vector<VideoCodecSettings>& recv_codecs,
@@ -2207,7 +2207,7 @@ WebRtcVideoChannel2::WebRtcVideoReceiveStream::WebRtcVideoReceiveStream(
ssrc_groups_(sp.ssrc_groups),
stream_(NULL),
default_stream_(default_stream),
- config_(config),
+ config_(std::move(config)),
red_disabled_by_remote_side_(red_disabled_by_remote_side),
external_decoder_factory_(external_decoder_factory),
sink_(NULL),
@@ -2384,13 +2384,13 @@ void WebRtcVideoChannel2::WebRtcVideoReceiveStream::RecreateWebRtcStream() {
if (stream_ != NULL) {
call_->DestroyVideoReceiveStream(stream_);
}
- webrtc::VideoReceiveStream::Config config = config_;
+ webrtc::VideoReceiveStream::Config config = config_.Copy();
if (red_disabled_by_remote_side_) {
config.rtp.fec.red_payload_type = -1;
config.rtp.fec.ulpfec_payload_type = -1;
config.rtp.fec.red_rtx_payload_type = -1;
}
- stream_ = call_->CreateVideoReceiveStream(config);
+ stream_ = call_->CreateVideoReceiveStream(std::move(config));
stream_->Start();
}

Powered by Google App Engine
This is Rietveld 408576698