Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: webrtc/call/call.cc

Issue 2042603002: Movable support for VideoReceiveStream::Config and avoid copies (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index e3c6ec7a0ccb5443e69dabb02dcb11f39f2460e0..b91048e38491a66104f2483d4728d73cf34cf088 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -76,7 +76,7 @@ class Call : public webrtc::Call,
void DestroyVideoSendStream(webrtc::VideoSendStream* send_stream) override;
webrtc::VideoReceiveStream* CreateVideoReceiveStream(
- const webrtc::VideoReceiveStream::Config& config) override;
+ webrtc::VideoReceiveStream::Config configuration) override;
void DestroyVideoReceiveStream(
webrtc::VideoReceiveStream* receive_stream) override;
@@ -466,12 +466,14 @@ void Call::DestroyVideoSendStream(webrtc::VideoSendStream* send_stream) {
}
webrtc::VideoReceiveStream* Call::CreateVideoReceiveStream(
- const webrtc::VideoReceiveStream::Config& config) {
+ webrtc::VideoReceiveStream::Config configuration) {
TRACE_EVENT0("webrtc", "Call::CreateVideoReceiveStream");
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
VideoReceiveStream* receive_stream = new VideoReceiveStream(
- num_cpu_cores_, congestion_controller_.get(), config, voice_engine(),
- module_process_thread_.get(), call_stats_.get(), &remb_);
+ num_cpu_cores_, congestion_controller_.get(), std::move(configuration),
+ voice_engine(), module_process_thread_.get(), call_stats_.get(), &remb_);
+
+ const webrtc::VideoReceiveStream::Config& config = receive_stream->config();
{
WriteLockScoped write_lock(*receive_crit_);
RTC_DCHECK(video_receive_ssrcs_.find(config.rtp.remote_ssrc) ==

Powered by Google App Engine
This is Rietveld 408576698