Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: webrtc/video/replay.cc

Issue 2042603002: Movable support for VideoReceiveStream::Config and avoid copies (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add TODO Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/receive_statistics_proxy.cc ('k') | webrtc/video/rtp_stream_receiver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 decoder = test::CreateMatchingDecoder(encoder_settings); 244 decoder = test::CreateMatchingDecoder(encoder_settings);
245 if (!flags::DecoderBitstreamFilename().empty()) { 245 if (!flags::DecoderBitstreamFilename().empty()) {
246 // Replace with a null decoder if we're writing the bitstream to a file 246 // Replace with a null decoder if we're writing the bitstream to a file
247 // instead. 247 // instead.
248 delete decoder.decoder; 248 delete decoder.decoder;
249 decoder.decoder = new test::FakeNullDecoder(); 249 decoder.decoder = new test::FakeNullDecoder();
250 } 250 }
251 receive_config.decoders.push_back(decoder); 251 receive_config.decoders.push_back(decoder);
252 252
253 VideoReceiveStream* receive_stream = 253 VideoReceiveStream* receive_stream =
254 call->CreateVideoReceiveStream(receive_config); 254 call->CreateVideoReceiveStream(std::move(receive_config));
255 255
256 std::unique_ptr<test::RtpFileReader> rtp_reader(test::RtpFileReader::Create( 256 std::unique_ptr<test::RtpFileReader> rtp_reader(test::RtpFileReader::Create(
257 test::RtpFileReader::kRtpDump, flags::InputFile())); 257 test::RtpFileReader::kRtpDump, flags::InputFile()));
258 if (!rtp_reader) { 258 if (!rtp_reader) {
259 rtp_reader.reset(test::RtpFileReader::Create(test::RtpFileReader::kPcap, 259 rtp_reader.reset(test::RtpFileReader::Create(test::RtpFileReader::kPcap,
260 flags::InputFile())); 260 flags::InputFile()));
261 if (!rtp_reader) { 261 if (!rtp_reader) {
262 fprintf(stderr, 262 fprintf(stderr,
263 "Couldn't open input file as either a rtpdump or .pcap. Note " 263 "Couldn't open input file as either a rtpdump or .pcap. Note "
264 "that .pcapng is not supported.\nTrying to interpret the file as " 264 "that .pcapng is not supported.\nTrying to interpret the file as "
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 } 319 }
320 } // namespace webrtc 320 } // namespace webrtc
321 321
322 int main(int argc, char* argv[]) { 322 int main(int argc, char* argv[]) {
323 ::testing::InitGoogleTest(&argc, argv); 323 ::testing::InitGoogleTest(&argc, argv);
324 google::ParseCommandLineFlags(&argc, &argv, true); 324 google::ParseCommandLineFlags(&argc, &argv, true);
325 325
326 webrtc::test::RunTest(webrtc::RtpReplay); 326 webrtc::test::RunTest(webrtc::RtpReplay);
327 return 0; 327 return 0;
328 } 328 }
OLDNEW
« no previous file with comments | « webrtc/video/receive_statistics_proxy.cc ('k') | webrtc/video/rtp_stream_receiver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698