Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2042283004: Use a video renderer instead of a capture observer in VideoCapturerAndroidTest. (Closed)

Created:
4 years, 6 months ago by sakal
Modified:
4 years, 6 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use a video renderer instead of a capture observer in VideoCapturerAndroidTest. In org.webrtc.VideoCapturerAndroidTest#startWhileCameraIsAlreadyOpenAndCloseCamera, use a video renderer instead of a capture observer. The video renderer automatically returns the texture buffers, which resolves the bug. There shouldn't be any changes to the effectiveness of the test. BUG=webrtc:5982 Committed: https://crrev.com/d9f3d56bb656e5baf7a9321ac60419c2514cdcbf Cr-Commit-Position: refs/heads/master@{#13085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
sakal
Per, take a look please.
4 years, 6 months ago (2016-06-08 15:31:35 UTC) #4
perkj_webrtc
lgtm
4 years, 6 months ago (2016-06-08 15:37:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042283004/1
4 years, 6 months ago (2016-06-09 07:15:07 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 07:50:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042283004/1
4 years, 6 months ago (2016-06-09 07:54:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 07:56:22 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 07:56:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9f3d56bb656e5baf7a9321ac60419c2514cdcbf
Cr-Commit-Position: refs/heads/master@{#13085}

Powered by Google App Engine
This is Rietveld 408576698