Revert "Revert of Update the BWE when the network route changes. (patchset #5 id:180001 of https://…

webrtc/p2p/base/port.h

Index: webrtc/p2p/base/port.h
diff --git a/webrtc/p2p/base/port.h b/webrtc/p2p/base/port.h
index 06efd2d3c235c4e976fda6f610c187741ac7542f..40ac22035708578de022a322b23a55f810205c6a 100644
--- a/webrtc/p2p/base/port.h
+++ b/webrtc/p2p/base/port.h
@@ -484,6 +484,11 @@ class Connection : public CandidatePairInterface,
   // Error if Send() returns < 0
   virtual int GetError() = 0;
 
+  virtual bool ReadyToSendMedia() const {

[pthatcher1, 2016/06/08 18:26:39]

Why not just connected()?

[honghaiz3, 2016/06/08 18:36:42]

connected() has already been used in the class.

[pthatcher1, 2016/06/08 18:46:58]

Ah, now you make me realize that this is almost the same as writable().   We're
just distinguishing between weakly and strongly writable.  Does it really matter
for the BWE?  Could we just use writable() instead of adding a new one?

Having connected, writable, and ReadyToSendMedia is getting to be a bit too many
things.

[honghaiz3, 2016/06/09 16:37:34]

See my reply in the email (and the post of this change). 
Plus, this does not add new state, just a method derived from the write_state_.
I put it along with other convenience methods relying on write_state_.  

+    return write_state_ == STATE_WRITABLE ||
+           write_state_ == STATE_WRITE_UNRELIABLE;
+  }
+
   sigslot::signal4<Connection*, const char*, size_t, const rtc::PacketTime&>
       SignalReadPacket;