GN: Add modules_unittests

GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  * webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  * webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac. Also ran:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and verified that more objects are being built (1885 vs 1883)
when compiling modules_unittests.

NOTRY=True
NOPRESUBMIT=True

Committed: https://crrev.com/fb11424551dae924869ae54059cb1612836cb6f7
Cr-Commit-Position: refs/heads/master@{#13108}

[kjellander_webrtc, 2016-06-08 19:44:59]

Description was changed from

==========
GN: Add modules_unittests

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

to

==========
GN: Add modules_unittests

Renames webrtc/modules/audio_processing/echo_cancellation_unittest.cc to
echo_cancellation_bit_exact_unittest.cc to avoid object naming conflicts
that GN disallows.

Depends on https://codereview.webrtc.org/2040313004/

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

[kjellander_webrtc, 2016-06-08 19:54:24]

Description was changed from

==========
GN: Add modules_unittests

Renames webrtc/modules/audio_processing/echo_cancellation_unittest.cc to
echo_cancellation_bit_exact_unittest.cc to avoid object naming conflicts
that GN disallows.

Depends on https://codereview.webrtc.org/2040313004/

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

to

==========
GN: Add modules_unittests

Renames to avoid object naming conflicts that GN disallows:
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc
=> echo_cancellation_bit_exact_unittest.cc}
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc =>
vp9_screenshare_layers_unittest.cc} 

Depends on https://codereview.webrtc.org/2040313004/

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

[kjellander_webrtc, 2016-06-08 20:29:05]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-06-08 20:29:26]

Description was changed from

==========
GN: Add modules_unittests

Renames to avoid object naming conflicts that GN disallows:
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc
=> echo_cancellation_bit_exact_unittest.cc}
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc =>
vp9_screenshare_layers_unittest.cc} 

Depends on https://codereview.webrtc.org/2040313004/

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

to

==========
GN: Add modules_unittests

Renames to avoid object naming conflicts that GN disallows:
* webrtc/modules/audio_processing/{echo_cancellation_unittest.cc
=> echo_cancellation_bit_exact_unittest.cc}
* webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc 
=> vp9_screenshare_layers_unittest.cc} 

Depends on https://codereview.webrtc.org/2040313004/

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

[kjellander_webrtc, 2016-06-08 20:29:36]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-06-08 20:29:45]

Patchset #1 (id:40001) has been deleted

[kjellander_webrtc, 2016-06-08 20:29:56]

Patchset #1 (id:60001) has been deleted

[kjellander_webrtc, 2016-06-08 20:30:04]

Patchset #1 (id:80001) has been deleted

[kjellander_webrtc, 2016-06-09 09:39:48]

Description was changed from

==========
GN: Add modules_unittests

Renames to avoid object naming conflicts that GN disallows:
* webrtc/modules/audio_processing/{echo_cancellation_unittest.cc
=> echo_cancellation_bit_exact_unittest.cc}
* webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc 
=> vp9_screenshare_layers_unittest.cc} 

Depends on https://codereview.webrtc.org/2040313004/

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

to

==========
GN: Add modules_unittests

Renames to avoid object naming conflicts that GN disallows:
* webrtc/modules/audio_processing/{echo_cancellation_unittest.cc
=> echo_cancellation_bit_exact_unittest.cc}
* webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc 
=> vp9_screenshare_layers_unittest.cc} 


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

[kjellander_webrtc, 2016-06-09 09:57:15]

Patchset #1 (id:100001) has been deleted

[kjellander_webrtc, 2016-06-09 10:00:34]

Patchset #1 (id:120001) has been deleted

[kjellander_webrtc, 2016-06-09 11:50:24]

Patchset #3 (id:180001) has been deleted

[kjellander_webrtc, 2016-06-09 12:13:46]

Patchset #3 (id:200001) has been deleted

[kjellander_webrtc, 2016-06-09 13:47:48]

Patchset #3 (id:220001) has been deleted

[kjellander_webrtc, 2016-06-09 14:01:55]

Description was changed from

==========
GN: Add modules_unittests

Renames to avoid object naming conflicts that GN disallows:
* webrtc/modules/audio_processing/{echo_cancellation_unittest.cc
=> echo_cancellation_bit_exact_unittest.cc}
* webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc 
=> vp9_screenshare_layers_unittest.cc} 


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

to

==========
GN: Add modules_unittests

Enables protobuf for iOS globally.

Renames to avoid object naming conflicts that GN disallows:
* webrtc/modules/audio_processing/{echo_cancellation_unittest.cc
=> echo_cancellation_bit_exact_unittest.cc}
* webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc 
=> vp9_screenshare_layers_unittest.cc} 


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

[kjellander_webrtc, 2016-06-09 14:06:37]

Description was changed from

==========
GN: Add modules_unittests

Enables protobuf for iOS globally.

Renames to avoid object naming conflicts that GN disallows:
* webrtc/modules/audio_processing/{echo_cancellation_unittest.cc
=> echo_cancellation_bit_exact_unittest.cc}
* webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc 
=> vp9_screenshare_layers_unittest.cc} 


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

to

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

[kjellander_webrtc, 2016-06-09 14:06:37]

kjellander@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, stefan@webrtc.org

[kjellander_webrtc, 2016-06-09 14:07:03]

Description was changed from

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
==========

to

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
==========

[kjellander_webrtc, 2016-06-09 14:10:45]

henrik.lundin: main review
stefan: video_coding/codecs/vp9/screenshare_layers_unittest.cc rename (let me
know if you want to do a large rename including the class being tested etc).

[hlundin-webrtc, 2016-06-10 09:45:14]

lgtm

[stefan-webrtc, 2016-06-10 11:27:08]

Did you also build with the flag to enable bwe test logging?
(-Denable_bwe_test_logging=1 for gyp)

[kjellander_webrtc, 2016-06-10 20:45:46]

On 2016/06/10 11:27:08, stefan-webrtc (holmer) wrote:
> Did you also build with the flag to enable bwe test logging?
> (-Denable_bwe_test_logging=1 for gyp)

Yes, I verified it works to run:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and that more objects are being built (1885 vs 1883) when compiling
modules_unittests.

[kjellander_webrtc, 2016-06-10 20:46:12]

Description was changed from

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac.
NOTRY=True
==========

to

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac. Also ran:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and verified that more objects are being built (1885 vs 1883)
when compiling modules_unittests.

NOTRY=True
==========

[stefan-webrtc, 2016-06-10 20:47:26]

On 2016/06/10 20:45:46, kjellander_webrtc wrote:
> On 2016/06/10 11:27:08, stefan-webrtc (holmer) wrote:
> > Did you also build with the flag to enable bwe test logging?
> > (-Denable_bwe_test_logging=1 for gyp)
> 
> Yes, I verified it works to run:
> gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
> and that more objects are being built (1885 vs 1883) when compiling
> modules_unittests.

Thanks, lgtm

[kjellander_webrtc, 2016-06-13 06:03:17]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-06-13 06:03:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041233006/260001

[commit-bot: I haz the power, 2016-06-13 06:05:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 06:05:34]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6224)

[kjellander_webrtc, 2016-06-13 07:03:19]

Description was changed from

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac. Also ran:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and verified that more objects are being built (1885 vs 1883)
when compiling modules_unittests.

NOTRY=True
==========

to

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac. Also ran:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and verified that more objects are being built (1885 vs 1883)
when compiling modules_unittests.

NOTRY=True
NOPRESUBMIT=True
==========

[kjellander_webrtc, 2016-06-13 07:19:34]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-06-13 07:19:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2041233006/#ps320001 (title:
"Correct path to base.gyp")

[commit-bot: I haz the power, 2016-06-13 07:19:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041233006/320001

[commit-bot: I haz the power, 2016-06-13 07:19:52]

Description was changed from

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac. Also ran:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and verified that more objects are being built (1885 vs 1883)
when compiling modules_unittests.

NOTRY=True
NOPRESUBMIT=True
==========

to

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac. Also ran:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and verified that more objects are being built (1885 vs 1883)
when compiling modules_unittests.

NOTRY=True
NOPRESUBMIT=True
==========

[commit-bot: I haz the power, 2016-06-13 07:19:53]

Committed patchset #7 (id:320001)

[commit-bot: I haz the power, 2016-06-13 07:19:58]

Description was changed from

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}


BUG=webrtc:5949
TESTED=Built and ran the tests on Mac. Also ran:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and verified that more objects are being built (1885 vs 1883)
when compiling modules_unittests.

NOTRY=True
NOPRESUBMIT=True
==========

to

==========
GN: Add modules_unittests

Changes:
* Enabled protobuf for iOS globally.
* Set WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE on a global
scope similar to GYP since tests depend on it.
* Added missing rtc_libvpx_build_vp9 variable.
* Moved out audio_coding defines into .gni file to avoid code duplication
* Renamed files to avoid object naming conflicts that GN disallows:
  *
webrtc/modules/audio_processing/{echo_cancellation_unittest.cc->echo_cancellation_bit_exact_unittest.cc}
  *
webrtc/modules/video_coding/codecs/vp9/{screenshare_layers_unittest.cc->vp9_screenshare_layers_unittest.cc}

BUG=webrtc:5949
TESTED=Built and ran the tests on Mac. Also ran:
gn gen out/Default --args="rtc_enable_bwe_test_logging=true"
and verified that more objects are being built (1885 vs 1883)
when compiling modules_unittests.

NOTRY=True
NOPRESUBMIT=True

Committed: https://crrev.com/fb11424551dae924869ae54059cb1612836cb6f7
Cr-Commit-Position: refs/heads/master@{#13108}
==========

[commit-bot: I haz the power, 2016-06-13 07:19:59]

Patchset 7 (id:??) landed as
https://crrev.com/fb11424551dae924869ae54059cb1612836cb6f7
Cr-Commit-Position: refs/heads/master@{#13108}